Fix non-standard white space#109
Merged
marshallward merged 3 commits intoApr 14, 2022
Merged
Conversation
Made widespread corrections to indentation and other white space issues to conform to the MOM6 standards, as documented in the white space section of the MOM6 style guide, at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide. - MOM6 code uses a 2-point indent scheme. - There should be a space around all assignment (" = ") operators. - The names of optional arguments do not use whitespace, to differentiate them from assignments. - There is a space around the semicolons for stacked enddo statements. After this change, greping for '^ [a-zA-Z]', '^ [a-zA-Z]' or '^ [a-zA-Z]' does not find any lines in the MOM6 src or config_src/infra code. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #109 +/- ##
=========================================
Coverage 28.76% 28.76%
=========================================
Files 248 248
Lines 72968 72967 -1
=========================================
Hits 20990 20990
+ Misses 51978 51977 -1
Continue to review full report at Codecov.
|
marshallward
approved these changes
Apr 14, 2022
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15237 ✔️ Rebase is not possible, but I think squash-merge is OK here since the second commit looks very minor. |
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Mar 2, 2023
update how UFS names restarts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made widespread corrections to indentation and other white space issues to
conform to the MOM6 standards, as documented in the white space section of the
MOM6 style guide, at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide.
MOM6 code uses a 2-point indent scheme.
There should be a space around all assignment (" = ") operators.
The names of optional arguments do not use whitespace, to differentiate them
from assignments.
There is a space around the semicolons for stacked enddo statements.
After this change, greping for '^ [a-zA-Z]', '^ [a-zA-Z]' or '^ [a-zA-Z]'
does not find any lines in the MOM6 src or config_src/infra code. All answers
and output are bitwise identical.