+Remove append_substring#108
Merged
marshallward merged 2 commits intoApr 12, 2022
Merged
Conversation
Removed the unused and unnecessary function append_substring. All answers are bitwise identical, but an unused public interface is being eliminated.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #108 +/- ##
=========================================
Coverage 28.76% 28.76%
=========================================
Files 248 248
Lines 72982 72968 -14
=========================================
Hits 20990 20990
+ Misses 51992 51978 -14
Continue to review full report at Codecov.
|
marshallward
approved these changes
Apr 12, 2022
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15229 ✔️ |
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Feb 8, 2023
use ungridded dimension for pstokes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the unused and unnecessary function append_substring. All answers
are bitwise identical, but an unused public interface is being eliminated.