Correct --with-driver args for coupled tests#106
Merged
Hallberg-NOAA merged 2 commits intoApr 10, 2022
Conversation
- Ever since a renaming of driver directories, the tests under "test-top-api", that are meant to check we are compatible with each "cap", have been failing silently. - This fixes the wrong arguments but does not fix the ability to fail silently which is somewhere deep inside mkmf.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #106 +/- ##
=========================================
Coverage 28.75% 28.75%
=========================================
Files 248 248
Lines 72970 72970
=========================================
Hits 20979 20979
Misses 51991 51991 Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Apr 10, 2022
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Because this does not alter any of the code that would be exercised by the pipeline testing, the successful TC testing is sufficient in this case.
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Feb 8, 2023
update to main 20221112 commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each "cap", have been failing silently.