Skip to content

Main to GFDL (2025-01-28)#1026

Closed
marshallward wants to merge 1 commit into
NOAA-GFDL:dev/gfdlfrom
marshallward:main-to-gfdl-20250128
Closed

Main to GFDL (2025-01-28)#1026
marshallward wants to merge 1 commit into
NOAA-GFDL:dev/gfdlfrom
marshallward:main-to-gfdl-20250128

Conversation

@marshallward
Copy link
Copy Markdown
Member

Merging the recent updates to main into dev/gfdl.

This includes mom-ocean#1675 and fixes from mom-ocean#1680.

This PR should be merged outside of GitHub (e.g. command-line). Do not use GitHub merging.

@marshallward
Copy link
Copy Markdown
Member Author

marshallward commented Jan 28, 2026

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29943 ✔️

This is ready to merge after review and approval.

Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These added changes seem innocuous to me.

@Hallberg-NOAA
Copy link
Copy Markdown
Member

The contents of this PR have been merged into dev/gfdl (via a merge commit), so this PR can now be closed.

@marshallward
Copy link
Copy Markdown
Member Author

It should have closed on its own. I think I made a mistake in the merge.

Reopening this until its sorted out.

@marshallward marshallward reopened this Feb 1, 2026
@marshallward
Copy link
Copy Markdown
Member Author

I see all of the commits. I don't know why this didn't auto-close. I guess we just move on.

@marshallward
Copy link
Copy Markdown
Member Author

marshallward commented Feb 2, 2026

Ok, it just has a different "merge" commit from the actual merge commit.

Normally I test the same branch that I merge, but in this case I repeated the merge on a new branch. Identical code, nearly identical history, but different hashes (due to timestamps, etc). So nothing unusual here.

In the future, if we want these PRs to auto-close, we should use the same PR for testing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants