Standardized syntax in mask2d logical tests#102
Merged
marshallward merged 2 commits intoApr 11, 2022
Conversation
Modified the syntax of the logical comparisons with the various mask2d variables to always check whether they are larger than 0.0, not 0.5 and use similar syntax throughout the MOM6 code. Because these arrays are always either 0.0 or 1.0, the answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #102 +/- ##
=========================================
Coverage 28.75% 28.75%
=========================================
Files 248 248
Lines 72976 72974 -2
=========================================
Hits 20985 20985
+ Misses 51991 51989 -2
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15215 ✔️ |
marshallward
approved these changes
Apr 11, 2022
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Sep 12, 2022
update to MOM6 20220820 main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the syntax of the logical comparisons with the various mask2d
variables to always check whether they are larger than 0.0, not 0.5 and use
similar syntax throughout the MOM6 code. Because these arrays are always either
0.0 or 1.0, the answers are bitwise identical.