MOM6-examples: Explicitly set 5 parameters to default values#313
Merged
Conversation
Explicitly set several parameters to their current default values in SIS_input and MOM_input files, so that answers in the MOM6-examples test suite will not change when the defaults of these parameters are changed in the MOM6 code. The parameters that are set in several files include USE_TRIPOLAR_GEOLONB_BUG, GRID_ROTATION_ANGLE_BUGS, FIX_UNSPLIT_DT_VISC_BUG and BULKML_CONV_MOMENTUM_BUG. DEFAULT_2018_ANSWERS is set to true for lock_exchange/MOM_input. All answers are bitwise identical.
adcroft
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set several parameters to their current default values in SIS_input
and MOM_input files, so that answers in the MOM6-examples test suite will not
change when the defaults of these parameters are changed in the MOM6 code. The
parameters that are set in several files include USE_TRIPOLAR_GEOLONB_BUG,
GRID_ROTATION_ANGLE_BUGS, FIX_UNSPLIT_DT_VISC_BUG and BULKML_CONV_MOMENTUM_BUG.
DEFAULT_2018_ANSWERS is set to true for lock_exchange/MOM_input. All answers
are bitwise identical.