changes dz_min from defined constant to a namelist option#76
Merged
Conversation
bensonr
requested review from
XiaqiongZhou-NOAA,
junwang-noaa and
laurenchilutti
XiaqiongZhou-NOAA
approved these changes
Mar 16, 2021
Contributor
XiaqiongZhou-NOAA
left a comment
XiaqiongZhou-NOAA
left a comment
There was a problem hiding this comment.
It looks fine to me.
Just wondering why not merge the EMC fork to GFDL emc/dev since these are already included in the EMC fork.
Should the description be added in fv_control.F90 as before ? " !> \param[in] dz_min Real: Minimum layer thickness to enforce monotonicity of height to prevent blowup. Set to 2 by default."
laurenchilutti
approved these changes
Mar 16, 2021
Contributor
Author
|
@XiaqiongZhou-NOAA - I didn't try using the existing PR because I was
concerned the different commit history might throw the synchronization
off. Plus, I want the dz_min commit to come in by itself as there is a
possibility of it coming back into master.
|
Contributor
|
Hi, all. I believe that Xi and I had been discussing this earlier: for
height processes, you always want to go bottom-up.
Thanks,
Lucas
…On Wed, Mar 17, 2021 at 3:19 PM bensonr ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In model/nh_utils.F90
<#76 (comment)>
:
> @@ -195,7 +194,7 @@ subroutine update_dz_c(is, ie, js, je, km, ng, dt, dp0, zs, area, ut, vt, gz, ws
6000 continue
! Enforce monotonicity of height to prevent blowup
-!$OMP parallel do default(none) shared(is1,ie1,js1,je1,ws,zs,gz,rdt,km)
+!$OMP parallel do default(none) shared(is1,ie1,js1,je1,ws,zs,gz,rdt,km,dz_min)
do j=js1, je1
do k=2, km+1
After discussions with @junwang-noaa <https://github.com/junwang-noaa>, I
have included the master version of the height monotonicity constraint for
update_dz_*
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVATO5COCSGNZYVXK33TED6CDANCNFSM4ZI6HFWA>
.
|
Collaborator
|
Yes, that (go bottom-up) is in the latest dev/emc branch at EMC fork, the
same as GFDL master branch
…On Wed, Mar 17, 2021 at 3:56 PM lharris4 ***@***.***> wrote:
Hi, all. I believe that Xi and I had been discussing this earlier: for
height processes, you always want to go bottom-up.
Thanks,
Lucas
On Wed, Mar 17, 2021 at 3:19 PM bensonr ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In model/nh_utils.F90
> <
#76 (comment)
>
> :
>
> > @@ -195,7 +194,7 @@ subroutine update_dz_c(is, ie, js, je, km, ng, dt,
dp0, zs, area, ut, vt, gz, ws
> 6000 continue
>
> ! Enforce monotonicity of height to prevent blowup
> -!$OMP parallel do default(none) shared(is1,ie1,js1,je1,ws,zs,gz,rdt,km)
> +!$OMP parallel do default(none)
shared(is1,ie1,js1,je1,ws,zs,gz,rdt,km,dz_min)
> do j=js1, je1
> do k=2, km+1
>
> After discussions with @junwang-noaa <https://github.com/junwang-noaa>,
I
> have included the master version of the height monotonicity constraint
for
> update_dz_*
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#76 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AMUQRVATO5COCSGNZYVXK33TED6CDANCNFSM4ZI6HFWA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNIH5X54EP2PX755KTTEECODANCNFSM4ZI6HFWA>
.
|
Contributor
Author
|
I remember the discussion and am glad @junwang-noaa brought it to my attention when reviewing the dz_min changes - even though it wasn't part of this particular PR. |
junwang-noaa
approved these changes
Mar 17, 2021
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
binli2337
added a commit
to binli2337/GFDL_atmos_cubed_sphere
that referenced
this pull request
Dec 4, 2022
* fixes io performance issues by making everyone a reader when io_layout=1,1 adds capability to use FMS feature to ignore data integrity checksums in restarts * rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility * updated UFS/GFS atmosphere.F90 driver as per @BinLiu-NOAA and @junwang-noaa * Regional decomposition test fix (when nrows_blend > 0) (NOAA-GFDL#194) * Add missing instance for hailwat * Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v. * atmosphere.F90 : add hailwat to check dyn_core.F90 : Fix from Jun Wang to correct sync of u,v fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1 * Explanatory comment added * Removed commented code * Clean old code * In fv_fill.F90, use kind_phys for kind_phys instead of hard-coding 8 byte reals. (NOAA-GFDL#193) * Expose remap_scalar and remap_dwinds to fv3-jedi (NOAA-GFDL#199) * changed interface to public * added public * removed source * mods for jedi build * Transfer changes from PR NOAA-GFDL#202 to NOAA-GFDL#199 Made small changes from PR NOAA-GFDL#202 manually. * returned ignore checksum * fixed ignore checksum * Fix several bugs in fv_regional_bc.F90 relating to uninitialized or incorrectly initialized memory. (NOAA-GFDL#219) * fixes and workarounds for uninitialized memory in fv_regional_bc * remove workarounds and fix remaining known bugs in ps_reg * a few more surface pressure bug fixes; now the test case runs in debug mode * workarounds and bug fixes from gnu compiler testing * remove -9999999 commented-out code * quiet the NaNs passed to Atmp%ps * simplify comments and explain snan * use i-1 & j-1 for two-point averages, when available * Replace many changes with PR NOAA-GFDL#220 Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov> Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com> Co-authored-by: Rusty Benson <6594772+bensonr@users.noreply.github.com> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com>
binli2337
pushed a commit
to binli2337/GFDL_atmos_cubed_sphere
that referenced
this pull request
Dec 4, 2022
This reverts commit 0ab12b6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of the synchronization process for dev/emc branch within the NOAA-GFDL organization.