Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conditional L1863 #366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmerlis
Copy link

@tmerlis tmerlis commented Dec 13, 2024

Description

The conditional to calculate vorticity-related diagnostics, including storm relative helicity SRH, resolves to "TRUE" if the relative humidity diagnostic is active. It's a one character typo: id_rh .neq. id_srh

Fixes # N/A I just noticed this when searching the code for id_rh

How Has This Been Tested?

It's a one character typo. Conceivably, some previous runs with some combinations of diag table variables will produce correct output (e.g., the case where only id_srh was true and no other vorticity diagnostics were requested will now work) or an unnecessary vorticity calculation is avoided (id_rh was true and no vorticity diagnostics requested).

Checklist:

Please check all whether they apply or not

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] Any dependent changes have been merged and published in downstream modules

@lharris4
Copy link
Contributor

The variable id_srh does not exist. I think the better option is to delete the conditional id_rh > 0 entirely.

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symbol id_srh does not exist. The best solution would be to delete .or. id_rh>0 altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants