allocate heat_source when SKEB is True and d_con is zero#351
Merged
Conversation
XiaqiongZhou-NOAA
approved these changes
Jul 17, 2024
lharris4
approved these changes
Jul 17, 2024
Contributor
lharris4
left a comment
lharris4
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for submitting this change.
bensonr
approved these changes
Jul 17, 2024
This was referenced Jul 18, 2024
|
#2278 is ready, please continue with the merge process, thank you. |
Contributor
|
@NeilBarton-NOAA - Did you create an issue for this PR? I want to make sure it gets closed. |
Author
|
@bensonr I did not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The model fails when d_con is zero and skeb is True because heat_source is unallocated. This change allocates heat_source when skeb is True
Fixes # (issue)
No issue previously assigned.
How Has This Been Tested?
The code has been tested in the gefs forecasting in g-w. Currently testing rt.
Checklist:
Please check all whether they apply or not