fix GNU out-of-bounds error in a diagnostic in GFDL driver#35
Merged
Conversation
mlee03
approved these changes
Apr 27, 2020
Contributor
|
Hi, Rusty. Looks good to me.
Thanks,
Lucas
…On Mon, Apr 27, 2020 at 2:48 PM MiKyung Lee ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVFFTNFB7WQWUUBYOXTROXHQ7ANCNFSM4MSFJNRA>
.
|
laurenchilutti
approved these changes
Apr 27, 2020
thomas-robinson
approved these changes
Apr 28, 2020
Member
thomas-robinson
left a comment
thomas-robinson
left a comment
There was a problem hiding this comment.
I tested with the AWG XML c96L33_am4p0. It ran with gfortran and reproduced with intel compiler.
Member
|
@bensonr This also moves the test case nml. Do you want to combine that with the gnu fix? |
Contributor
Author
|
@thomas-robinson Both fixes are in this PR and @mlee03 has already tested the namelist fix. I'm not sure I understand your question? |
Member
|
@bensonr You answered it. I just wanted to be sure these two things were tested and were meant to be in a single PR. |
bensonr
added a commit
that referenced
this pull request
Apr 28, 2020
pull latest master updates (PR #35) into dev/gfdl
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Nov 19, 2020
* add GFSv16 dzmin change * Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda, dycore PR NOAA-GFDL#35 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Dan Holdaway <dan.holdaway@nasa.govr>
MicroTed
pushed a commit
to MicroTed/GFDL_atmos_cubed_sphere
that referenced
this pull request
Sep 22, 2021
* fv3atm issue NOAA-GFDL#37: fix the real(8) lat/lon in netcdf file * fv3atm NOAA-GFDL#35: Reducing background vertical diffusivities in the inversion layers * fv3atm NOAA-GFDL#24: bug in gfsphysics/physics/moninedmf_hafs.f * fv3atm NOAA-GFDL#18: Optimize netcdf write component and bugfix for post and samfdeepcnv.f * set (0-1) bounds for ficein_cpl * remove cache_size due to lower netcdf verion 4.5.1 on mars * Change ice falling to 0.9 in gfsphysics/physics/gfdl_cloud_microphys.F90
MicroTed
pushed a commit
to MicroTed/GFDL_atmos_cubed_sphere
that referenced
this pull request
Sep 22, 2021
* update post lib to upp lib and add dzmin change in fv3 dycore * add dycore change NOAA-GFDL#35 * merge with top of dev/emc dycore branch * remove duplicate read_data in fms_mod in external_ic.F90
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Fixes a missing namelist for the doubly-periodic model
Fixes a GNU out-of-bounds error in a diagnostic quantity in the GFDL driver (driver/GFDL/atmosphere.F90).
Once this pull request is merged into master, it will be merged into the dev/gfdl branch (already tested for automatic merge).