Adjust do loop bounds in a2b_ord2 to prevent reading from uninitialized memory#349
Merged
laurenchilutti merged 2 commits intoJul 16, 2024
Merged
Conversation
…tialized elements of qin array Input array qin in a2b_ord2 routine is declared as qin(is-ng:ie+ng,js-ng:je+ng) but only elements in (is-1:ie+1, js-1:je+1) range are initialized in a calling routine, for example pin array in adv_pe routine in dyn_core.F90
…MAKE_Fortran_FLAGS_DEBUG)
bensonr
approved these changes
Jul 12, 2024
XiaqiongZhou-NOAA
approved these changes
Jul 12, 2024
Contributor
XiaqiongZhou-NOAA
left a comment
XiaqiongZhou-NOAA
left a comment
There was a problem hiding this comment.
Loop i-, j-dimensions of qin are consistent with that in dyn_core.F90 now.
lharris4
approved these changes
Jul 12, 2024
Contributor
lharris4
left a comment
lharris4
left a comment
There was a problem hiding this comment.
This should be fine. Do keep an eye out for potential artifacts at nested and regional domain boundaries.
14 tasks
14 tasks
|
@bensonr testing on WM PR-2362 is complete. Can you please merge this cubed-sphere PR? |
|
@laurenchilutti This pr can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes occasional model crashes in debug mode caused by floating-point exception in subroutine
a2b_ord2inmodel/a2b_edge.F90. See issue #346 for details.In subroutine
a2b_ord2do loop bounds are changed to avoid reading from uninitialized elements ofqinarray.Intel Fortran compiler flag (
-init=snan,arrays) has been added to debug flags.Fixes #346
How Has This Been Tested?
Several debug ufs-weather-model regression tests have been run on Hera and few other NOAA systems successfully. I will run full regression test on Hera.
Checklist:
Please check all whether they apply or not