Perturbation/Increments for cold starts#340
Merged
Merged
Conversation
This was referenced May 8, 2024
Member
|
Do you have a suggestion on from EMC or the UFS community can review this? |
Contributor
|
@pjpegion @laurenchilutti This looks OK to me. There is no reason we can't use this method to apply to arbitrary initialization methods (restart, external_ic, or ideal). |
bensonr
approved these changes
May 9, 2024
laurenchilutti
approved these changes
May 13, 2024
XiaqiongZhou-NOAA
approved these changes
May 21, 2024
sync with dev/emc
14 tasks
|
All tests are done ok at ufs-community/ufs-weather-model#2269. @bensonr @laurenchilutti can you merge this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the model can only read in an increment file if initializing with a restart file. This functionality is also used to read in ensemble perturbations, and should also work for a external initial condition. The solution is to move the call to read_da_inc outside the if external_ic/restart logic.
Fixes # (issue)
FV3 is not able to apply DA increment when cold staring #339
How Has This Been Tested?
So far, I have run limited regression tests on gaea, and tested that the perturbations are being read in during a cold start. The regression tests pass.
Checklist:
Please check all whether they apply or not