Write restart files using the write grid component in UFS#244
Conversation
…es on wrt grid comp
bensonr
left a comment
bensonr
left a comment
There was a problem hiding this comment.
We use the convention of north and east within FMS when referring to staggered variables. You are already using east and I suggest replacing south with north to keep the conventions the same.
Done. See 83f596d |
| core_east_var3_names(1) = 'v' | ||
| n = 1 | ||
| if (.not.atm%flagstruct%hydrostatic) then | ||
| if (atm%flagstruct%make_nh) then ! hydrostatic restarts dont have these variables |
There was a problem hiding this comment.
I am not sure if I understand correctly. But the lines 123-127 look the same as line 129-133, do we need this if statement?
| n = 1 | ||
| if (.not.atm%flagstruct%hydrostatic) then | ||
| if (atm%flagstruct%make_nh) then ! hydrostatic restarts dont have these variables | ||
| ! core_center_var3(n) = 'w'; n=n+1 |
There was a problem hiding this comment.
Not sure if I understand this if statement (and comments) . Isn't line 208 said that this is non-hydrostatic? Can we have:
if (.not. atm%flagstruct%make_nh) then
lines 216-220
endif
There was a problem hiding this comment.
|
all tests are done on ufs-community/ufs-weather-model#1633. @bensonr @laurenchilutti can you merge the pr? |
5 participants
Description
This PR adds new module that enables writing the restart files using the write grid component in UFS. The new module is located in driver/fvGFS/ and is only used by UFS.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
Please check all whether they apply or not