You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates add_field_to_bundle subroutine in driver/fvGFS/fv_nggps_diag.F90. The values used for esmf field attributes (_FillValue and missing_value) must be the same real kind as the field data values, in this case REAL(4) in order to avoid type mismatch checks in PIO library which is used by ESMF I/O module.
@DusanJovic-NOAA Since the data buffer is in real(4) for dyn history outputs, can we just change line #106 to real(4)?
missing_value is also used in other subroutines like hailcast_init and register_diag_field and the corresponding dummy arguments are declared as default real (either 4-byte or 8-byte depending on the compile options). So if we explicitly declare missing_value as real(4) that will introduce argument mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
add_field_to_bundlesubroutine in driver/fvGFS/fv_nggps_diag.F90. The values used for esmf field attributes (_FillValueandmissing_value) must be the same real kind as the field data values, in this case REAL(4) in order to avoid type mismatch checks in PIO library which is used by ESMF I/O module.See: ufs-community/ufs-weather-model#1564
How Has This Been Tested?
Full usf-weather-model regression test on Hera.
Checklist:
Please check all whether they apply or not