Update RELEASE.md with tech note pointer#22
Merged
Conversation
Contributor
Author
|
@lharris4 - could you please review this pull request to NOAA-GFDL/GFDL_atmos_cubed_sphere? |
laurenchilutti
approved these changes
Apr 20, 2020
breaks up a too long line in fv_nesting.F90
Contributor
|
Hi, Rusty. Thanks. It looks good. The only additional change (which was
caught by Kate) that I forgot to upload was to change the default value of
nestupdate in fv_array.F90 from 0 to 7.
Lucas
…On Mon, Apr 20, 2020 at 3:42 PM bensonr ***@***.***> wrote:
@lharris4 <https://github.com/lharris4> - could you please review this
pull request to NOAA-GFDL/GFDL_atmos_cubed_sphere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVDOPB3MPUW4RAUQECLRNSQQJANCNFSM4MMW2WVA>
.
|
Contributor
Author
|
@lharris4 - the default value of nestupdate is now 7. If there are no other updates, I'll merge these changes into master and update the release tag. |
Contributor
|
Hi, Rusty. I think that is all.
Thanks for your help.
Lucas
…On Mon, Apr 20, 2020 at 10:38 PM bensonr ***@***.***> wrote:
@lharris4 <https://github.com/lharris4> - the default value of nestupdate
is now 7. If there are no other updates, I'll merge these changes into
master and update the release tag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVDFDBFJEPOYKRSSYNDRNUBLLANCNFSM4MMW2WVA>
.
|
climbfuji
added a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jun 24, 2020
* Fixes for GNU compilation issues (NOAA-GFDL#32) * Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control * Remove the fix for mesh generation and it will be fixed later * fix GNU out-of-bound error in driver/fvGFS/atmosphere.F90 * Correct Z dimensions in driver/fvGFS/atmosphere.F90 Co-authored-by: Xiaqiong Zhou <Xiaqiong.Zhou@noaa.gov>
christinaholtNOAA
pushed a commit
to NOAA-GSL/GFDL_atmos_cubed_sphere
that referenced
this pull request
May 25, 2021
* Fixes for GNU compilation issues (NOAA-GFDL#32) * Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control * Remove the fix for mesh generation and it will be fixed later * fix GNU out-of-bound error in driver/fvGFS/atmosphere.F90 * Correct Z dimensions in driver/fvGFS/atmosphere.F90 Co-authored-by: Xiaqiong Zhou <Xiaqiong.Zhou@noaa.gov>
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
…L#21-use-gftl-shared Fixes NOAA-GFDL#21 - use gFTL-shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed trailing whitespace and tab characters from all source files.