starting on autotools...

[edhartnett]

Here's the beginning of the autotools build.

I build this with:
autoreconf -i && CC=mpicc FC=mpifort CPPFLAGS=-I/usr/local/fms/include LDFLAGS=-L/usr/local/fms/lib ./configure && make clean && make check

It starts by trying to build in directory driver/GFDL, and fails like this:

Making check in GFDL
make[2]: Entering directory '/home/ed/tmp/GFDL_atmos_cubed_sphere/driver/GFDL'
mpifort -DPACKAGE_NAME=\"GFDL_atmos_cubed_shere\" -DPACKAGE_TARNAME=\"gfdl_atmos_cubed_shere\" -DPACKAGE_VERSION=\"2.0-development\" -DPACKAGE_STRING=\"GFDL_atmos_cubed_shere\ 2.0-development\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"gfdl_atmos_cubed_shere\" -DVERSION=\"2.0-development\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -Duse_netCDF=1 -Duse_libMPI=1 -I.   -I/usr/local/fms/include  -g -O2 -c -o atmosphere.o atmosphere.F90
/usr/local/fms/include/fms_platform.h:114:0:

 #define QUAD_KIND DOUBLE_KIND
 
Warning: "QUAD_KIND" redefined
/usr/local/fms/include/fms_platform.h:39:0:

 #define QUAD_KIND 16
 
note: this is the location of the previous definition
atmosphere.F90:33:4:

 use atmos_co2_mod,      only: atmos_co2_rad, co2_radiation_override
    1
Fatal Error: Can't open module file ‘atmos_co2_mod.mod’ for reading at (1): No such file or directory
compilation terminated.
Makefile:405: recipe for target 'atmosphere.o' failed
make[2]: *** [atmosphere.o] Error 1
make[2]: Leaving directory '/home/ed/tmp/GFDL_atmos_cubed_sphere/driver/GFDL'
Makefile:364: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/ed/tmp/GFDL_atmos_cubed_sphere/driver'
Makefile:395: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

I cannot find atmos_co2_mod in the FMS package. Where is it?

[wrongkindofdoctor]

@lharris4 @bensonr

atmos_co2 is in the atmos_shared/tracer_driver subdirectory of the AM4 repo:
https://github.com/NOAA-GFDL/AM4/tree/master/src/atmos_shared/tracer_driver. I'm not sure whether atmos_co2_rad and co2_radiation_override have been moved elsewhere in the in-house development stream, and have tagged the relevant folks in this response so we can correct the module.

[edhartnett]

OK, thanks for the answer!

I will grab that repo and try to build it...

[edhartnett]

OK, when I grab atmos_co2.F90 and attempt to build it I get this error. This kind of surpises me as I have FMS installed and diag_manager_mod.mod is present. Could you be using a different version?

mpifort -DPACKAGE_NAME=\"GFDL_atmos_cubed_shere\" -DPACKAGE_TARNAME=\"gfdl_atmos_cubed_shere\" -DPACKAGE_VERSION=\"2.0-development\" -DPACKAGE_STRING=\"GFDL_atmos_cubed_shere\ 2.0-development\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"gfdl_atmos_cubed_shere\" -DVERSION=\"2.0-development\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -Duse_netCDF=1 -Duse_libMPI=1 -I.   -I/usr/local/fms/include  -g -O2 -c -o atmos_co2.o atmos_co2.F90
atmos_co2.F90:627:20:

    id_co2restore  = register_diag_field ('atmos_co2_restoring', 'co2_restore', axes, Time, &
                    1
Error: There is no specific function for the generic ‘register_diag_field’ at (1)
atmos_co2.F90:631:15:

    id_pwt    = register_diag_field ('atmos_co2', 'pwt', axes, Time, &
               1
Error: There is no specific function for the generic ‘register_diag_field’ at (1)
atmos_co2.F90:635:22:

    id_co2_mol_emiss = register_diag_field ('atmos_co2_emissions', 'co2_mol_emission', axes(1:2), Time, &
                      1
Error: There is no specific function for the generic ‘register_diag_field’ at (1)
atmos_co2.F90:639:23:

    id_co2_emiss_orig = register_diag_field ('atmos_co2_emissions', 'co2_emissions_orig', axes(1:2), Time, &
                       1
Error: There is no specific function for the generic ‘register_diag_field’ at (1)
atmos_co2.F90:525:17:

   ind_co2_flux = aof_set_coupler_flux('co2_flux',                       &
                 1
Error: Type mismatch in argument ‘param’ at (1); passed REAL(4) to REAL(8)
atmos_co2.F90:384:75:

     call data_override('ATM', 'co2_emiss', co2_emis2d, Time, override=used)
                                                                           1
Error: There is no specific subroutine for the generic ‘data_override’ at (1)
atmos_co2.F90:392:88:

     call data_override('ATM', 'co2_dvmr_restore', restore_co2_dvmr, Time, override=used)
                                                                                        1
Error: There is no specific subroutine for the generic ‘data_override’ at (1)
atmos_co2.F90:341:36:

   if (id_co2_emiss_orig > 0) sent = send_data (id_co2_emiss_orig, co2_emis2d(is:ie,js:je), Time_next, is_in=is,js_in=js)
                                    1
Error: There is no specific function for the generic ‘send_data’ at (1)
atmos_co2.F90:251:84:

   call data_override('ATM', 'co2_dvmr_rad', radiation_co2_dvmr, Time, override=used)
                                                                                    1
Error: There is no specific subroutine for the generic ‘data_override’ at (1)
atmos_co2.F90:200:23:

 if (id_pwt > 0) sent = send_data (id_pwt, pwt, Time_next, is_in=is,js_in=js)
                       1
Error: There is no specific function for the generic ‘send_data’ at (1)
Makefile:412: recipe for target 'atmos_co2.o' failed
make[2]: *** [atmos_co2.o] Error 1
make[2]: Leaving directory '/home/ed/tmp/GFDL_atmos_cubed_sphere/driver/GFDL'
Makefile:364: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/ed/tmp/GFDL_atmos_cubed_sphere/driver'
Makefile:395: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

[wrongkindofdoctor]

Yes, it is likely that the development workflow differs from the one you are trying to build. I need @lharris4 and/or @bensonr to confirm.

[lharris4]

Hi, Jess. I have never used this file and I don't know anything about it. Thanks, Lucas

…

On Wed, Jul 24, 2019 at 5:02 AM Jess ***@***.***> wrote: Yes, it is likely that the development workflow differs from the one you are trying to build. I need @lharris4 <https://github.com/lharris4> and/or @bensonr <https://github.com/bensonr> to confirm. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AMUQRVHPKZZ3GJC6VABKUKDQA5WVJA5CNFSM4IGF33S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2UNWVI#issuecomment-514382677>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMUQRVFVJ43YRX27O2NBNHLQA5WVJANCNFSM4IGF33SQ> .

[edhartnett]

Well, let me ask this question: does this repo build for anyone there at GFDL? If so, can you send me your build output, so I can see what happens with this missing file? If not, could you fix the repo so that it can be built in some way? Thanks!

[lharris4]

Hi, Ed. You would need to ask Rusty or someone else who builds the version of the model that uses these files; Rusty or Huan would know more. Thanks, Lucas

…

On Wed, Jul 24, 2019 at 9:59 PM Ed Hartnett ***@***.***> wrote: Well, let me ask this question: does this repo build for anyone there at GFDL? If so, can you send me your build output, so I can see what happens with this missing file? If not, could you fix the repo so that it can be built in some way? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AMUQRVCNVIJENXKOH2VPMJLQBBN3ZA5CNFSM4IGF33S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WNQ6I#issuecomment-514644089>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMUQRVBW6NRQA32D77NUEKDQBBN3ZANCNFSM4IGF33SQ> .

[edhartnett]

How do you build the version of the model that does not use those files? If you can build this code, can you please send me your full build output? Thanks!

[bensonr]

Hi Ed, I just returned from travel and feel it is best to talk directly to you about this rather than going via email.

…

-- Rusty Benson Modeling Systems Division NOAA Geophysical Fluid Dynamics Lab Princeton, NJ 609.452.6539

On Wed, Jul 24, 2019 at 10:24 AM Ed Hartnett ***@***.***> wrote: How do you build the version of the model that does not use those files? If you can build this code, can you please send me your full build output? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=ABSKBVEVU4WHXQWJTXRL6IDQBBQ25A5CNFSM4IGF33S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WQBAQ#issuecomment-514654338>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABSKBVFVSYNAPVDWPMM3DPDQBBQ25ANCNFSM4IGF33SQ> .

[edhartnett]

Howdy @bensonr ! What's a good time to call you? I am free all day.

[edhartnett]

I have learned from rusty that the master branch on this repo is not really worth messing with. I will switch to the two active branches instead.

I urge the code managers of this project to make the decisions necessary to merge code to master. I understand that in the absence of a proper build system, it can be a challenge to integrate versions of the code developed for different purposes.

I will get a build system going for each of the two branches. Hopefully, there can then be an effort to merge changes to master and come up with a version of this code that everyone can use.