Dev/gfdl mixedmode#198
Merged
laurenchilutti merged 3 commits intoJun 24, 2022
Merged
Conversation
Conflicts: driver/SHiELD/atmosphere.F90 model/fv_dynamics.F90 model/fv_update_phys.F90 model/nh_core.F90 model/nh_utils.F90 tools/fv_nggps_diag.F90 tools/test_cases.F90
bensonr
reviewed
Jun 16, 2022
Contributor
bensonr
left a comment
bensonr
left a comment
There was a problem hiding this comment.
I'm concerned about the constants changes. One of the previous FMS updates re-organized the constants and until I see EMCs updates, I am unsure of how that folds into FV3.
Member
Author
|
@benonr I will leave this PR in review and we can revisit it when the FMS mixed mode merge is complete. |
bensonr
approved these changes
Jun 23, 2022
bensonr
approved these changes
Jun 23, 2022
Contributor
bensonr
left a comment
bensonr
left a comment
There was a problem hiding this comment.
We really don't need the use platform_mod, but they don't hurt.
laurenchilutti
added a commit
to laurenchilutti/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2022
* mixed mode emc squash commit Conflicts: driver/SHiELD/atmosphere.F90 model/fv_dynamics.F90 model/fv_update_phys.F90 model/nh_core.F90 model/nh_utils.F90 tools/fv_nggps_diag.F90 tools/test_cases.F90 * GNU compiler bug fix * removing constants changes as these wont be needed on dev/gfdl
laurenchilutti
added a commit
that referenced
this pull request
Aug 1, 2022
* mixed mode emc squash commit Conflicts: driver/SHiELD/atmosphere.F90 model/fv_dynamics.F90 model/fv_update_phys.F90 model/nh_core.F90 model/nh_utils.F90 tools/fv_nggps_diag.F90 tools/test_cases.F90 * GNU compiler bug fix * removing constants changes as these wont be needed on dev/gfdl
laurenchilutti
added a commit
to laurenchilutti/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jan 24, 2023
* mixed mode emc squash commit * GNU compiler bug fix * removing constants changes as these wont be needed on dev/gfdl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to dev/gfdl for implementation of mixed mode. This also includes a GNU fix that we need to make with these changes. This PR should be almost identical to the previous PR #172 in which we incorporated this previously. The only difference is that I manually added the
#ifdef OVERLOAD_R4to the constants in driver/GFDL/atmosphere.F90 - pleae review if this change is needed or if I should remove this. This will need to be merged for testing with FMS 2022.03-alpha1.Fixes # (issue)
How Has This Been Tested?
EMC has tested this. We will be testing this with FMS 2022.03-alpha1 when that is released.
Checklist:
Please check all whether they apply or not