Bug fix fv_regional_bc.F90: initialize cloud amount boundary conditions only if cloud amount is a valid tracer#146
Merged
laurenchilutti merged 1 commit intoOct 6, 2021
Conversation
…ions to zero only if cloud amount is being used by this model run
Author
|
I don't know what GitHub was doing, but this issue has not been solved yet. Reopening. |
bensonr
approved these changes
Sep 23, 2021
laurenchilutti
approved these changes
Sep 23, 2021
junwang-noaa
approved these changes
Sep 23, 2021
laurenchilutti
added a commit
that referenced
this pull request
Oct 6, 2021
…ud_amount Bug fix fv_regional_bc.F90: initialize cloud amount boundary conditions only if cloud amount is a valid tracer
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title says. In
model/fv_regional_bc.F90, initialize cloud amount boundary conditions to zero only if cloud amount is a valid tracer (i.e. if the index in the tracer array is > 0).Fixes #145
Tested in the latest ufs-weather-model for regression tests that are run only sporadically (
rt_ccpp_dev.conf), i.e. not as part of the standard Intel/GNU tests. This solves a crash with old input data that was generated for Thompson MP and doesn't have cloud amount.Checklist:
Please check all whether they apply or not