Skip to content

atmos_cubed_sphere#14

Merged
bensonr merged 9 commits into
NOAA-GFDL:dev/gfdlfrom
mlee03:rev_mkl_agreewithmath
Feb 7, 2020
Merged

atmos_cubed_sphere#14
bensonr merged 9 commits into
NOAA-GFDL:dev/gfdlfrom
mlee03:rev_mkl_agreewithmath

Conversation

@mlee03
Copy link
Copy Markdown

@mlee03 mlee03 commented Jan 17, 2020

Updates dev/gfdl to internal xanadu tag

@thomas-robinson
Copy link
Copy Markdown
Member

thomas-robinson commented Jan 17, 2020

@uramirez8707 can you please test this with AM4 to make sure it reproduces answers and diagnostics? Use am4p0 and am4p0_cmip6Diag

@uramirez8707
Copy link
Copy Markdown
Contributor

uramirez8707 commented Jan 17, 2020

@thomas-robinson check if it reproduces answers with xanadu, right?

@thomas-robinson
Copy link
Copy Markdown
Member

thomas-robinson commented Jan 17, 2020

Yes, it should reproduce xanadu

@uramirez8707
Copy link
Copy Markdown
Contributor

uramirez8707 commented Jan 21, 2020

@thomas-robinson @mlee03 restarts and diagnostics reproduce. I tried am4p0 and am4p0_cmip6Diag with intel 17 in debug, repro, and prod.

bensonr
bensonr requested changes Jan 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these files from the repository:
driver/GFDL/DIFF_DEC30
driver/GFDL/DIFF_JAN02
model/get_diff.sh~

model/fv_cmp.F90 was designed to be a "null" component as it's not needed for AM4 physics. Could you revert it back to the null version?

I see a lot of commented lines after fixed lines. Could you remove those commented lines?

@mlee03
Copy link
Copy Markdown
Author

mlee03 commented Jan 31, 2020

@bensonr

  1. All extraneous files have been deleted
  2. Model/fv_cmp.F90 has been reverted to its original version found in branch dev/gfdl
  3. All unnecessary comments have been removed from
    tools/external_ic.F90 and tools/fv_surf_map.F90

@thomas-robinson
Copy link
Copy Markdown
Member

thomas-robinson commented Jan 31, 2020 •
edited
Loading

@bensonr I would recommend doing a merge and squash to a single commit for this PR. Also, tagging this as xanadu will be helpful for internal GFDL use.

@thomas-robinson thomas-robinson mentioned this pull request Feb 7, 2020
Merged
8 tasks
@bensonr bensonr merged commit e8a55d3 into NOAA-GFDL:dev/gfdl Feb 7, 2020
climbfuji referenced this pull request in climbfuji/GFDL_atmos_cubed_sphere Mar 4, 2020
@junwang-noaa
Merge pull request NCAR#14 from jswhit2/iau_drymassfixer
db3acfb 
add dry mass fixer for IAU
@lharris4 lharris4 mentioned this pull request Apr 28, 2020
Closed
MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
@junwang-noaa
change ifmin to zero at fh00 for inline POST (NOAA-GFDL#14)
26de321
KevinViner-NOAA pushed a commit to KevinViner-NOAA/GFDL_atmos_cubed_sphere that referenced this pull request Mar 6, 2023
@SamuelTrahanNOAA
Merge pull request NOAA-GFDL#14 from SamuelTrahanNOAA/bugfix/RRFS_dev…
2625660 
…_debug_v3

latest version of fv_regional_bc.F90 bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bensonr bensonr bensonr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mlee03 @thomas-robinson @uramirez8707 @bensonr