Remove use_mpp_io from diag manager#940
Merged
Merged
Conversation
bensonr
reviewed
Mar 21, 2022
Contributor
bensonr
left a comment
There was a problem hiding this comment.
Looks good from what I can see.
Contributor
|
@thomas-robinson This doesn't actually have any duplication from #928 since I wasn't sure whether or not to get rid of the use_mpp_io namelist flag (if anyone still uses it). Of course, I could incorporate these changes into #928 if we feel like they should go together. |
Member
Author
|
Thanks @GFDL-Eric I think you should keep #928 as is, and let this be part of the diag manager modernization. Then we can remove the rest of |
GFDL-Eric
approved these changes
Mar 21, 2022
Contributor
|
@thomas-robinson sounds good! |
bensonr
approved these changes
Mar 21, 2022
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the variable
use_mpp_iofrom the diag manager.Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses