Dm update: diag_yaml_object_init() tests#883
Merged
Merged
Conversation
uramirez8707
requested review from
bensonr,
rem1776,
thomas-robinson and
wrongkindofdoctor
as code owners
uramirez8707
commented
Jan 10, 2022
Comment on lines
+70
to
+75
| function get_diag_yaml_obj() & | ||
| result(res) | ||
| type (diagYamlObject_type) :: res | ||
|
|
||
| res = diag_yaml | ||
| end function get_diag_yaml_obj |
Contributor
Author
There was a problem hiding this comment.
This was added for the test.
The test will get a copy for the private diag_yaml module variable, and then use the get_* functions to check for the correct values.
thomas-robinson
requested changes
Jan 11, 2022
| !! Try get_value_from_key using a r8 buffer | ||
| call get_value_from_key(yaml_file_id1, variable_ids(1), "fill_value", r8_buffer) | ||
| if (r8_buffer .ne. real(-999.9, kind=r8_kind)) call mpp_error(FATAL, "fill_value was not read correctly as an r8!") | ||
| if (abs(r8_buffer - real(-999.9, kind=r8_kind)) .gt. 5e-5) call mpp_error(FATAL, "fill_value was not read correctly as an r8!") |
Member
There was a problem hiding this comment.
Since this is using real*8s, I think you want to change the e to a d
abs(r8_buffer - real(-999.9, kind=r8_kind)) .gt. 5d-5
Contributor
Author
There was a problem hiding this comment.
@rem1776 This will need to be done in main first.
Contributor
There was a problem hiding this comment.
@uramirez8707 @thomas-robinson Just put in #886
Member
There was a problem hiding this comment.
@rem1776 #886 is approved.
@uramirez8707 are you going to merge it in and then we can merge this PR?
… use DIAG_NULL instead of hardcoding
thomas-robinson
approved these changes
Jan 12, 2022
Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
thomas-robinson
approved these changes
Jan 12, 2022
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
These new tests only run if using --with-yaml
Note: This PR includes updates from main
TO DO:
result()needs to be its own line)Fixes # (issue)
How Has This Been Tested?
make checkpasses with intel21 and gnu on SkylakeChecklist:
make distcheckpasses