Skip to content

Non-blocking domain updates bug fix#848

Merged
rem1776 merged 1 commit into
NOAA-GFDL:mainfrom
rem1776:domains_nonblock_fix
Nov 8, 2021
Merged

Non-blocking domain updates bug fix#848
rem1776 merged 1 commit into
NOAA-GFDL:mainfrom
rem1776:domains_nonblock_fix

Conversation

@rem1776
Copy link
Copy Markdown
Contributor

@rem1776 rem1776 commented Oct 20, 2021

Description
Initializes a logical array to false in the two non-blocking domain update routines. This fixes crashes and incorrect values from mpp_complete_update_domains by preventing unintentional updates from the undefined logical values.

Fixes #484

How Has This Been Tested?
Tested on amd with intel and gcc + impi, and with the domains tests enabled in #800

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 8981ef7 into NOAA-GFDL:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable mpp_domains tests in test_fms/mpp

3 participants