Skip to content

Write global/variable attributes defined in the yaml + subregional files update#1261

Merged
thomas-robinson merged 2 commits into
NOAA-GFDL:dmUpdatefrom
uramirez8707:add_att
Jun 28, 2023
Merged

Write global/variable attributes defined in the yaml + subregional files update#1261
thomas-robinson merged 2 commits into
NOAA-GFDL:dmUpdatefrom
uramirez8707:add_att

Conversation

@uramirez8707
Copy link
Copy Markdown
Contributor

@uramirez8707 uramirez8707 commented Jun 20, 2023

Description

  • Adds code to write out the global/variable attributes defined in the yaml
  • Writes out is_regional=.TRUE. as a global attribute if the file is subregional. This attribute is only going to exist if the file is subregional. FYI @ceblanton
  • Updates tests to make sure this works

Fixes #1242

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson merged commit 75228b0 into NOAA-GFDL:dmUpdate Jun 28, 2023
@uramirez8707 uramirez8707 deleted the add_att branch August 24, 2023 18:44
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
…les update (NOAA-GFDL#1261)

* Write global and variable attributes defined in the yaml to the file, and add global attribute if the file is sub-regional
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
…les update (NOAA-GFDL#1261)

* Write global and variable attributes defined in the yaml to the file, and add global attribute if the file is sub-regional
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants