Update to fms_diag_yaml_mod#1186
Merged
thomas-robinson merged 7 commits intoApr 25, 2023
Merged
Conversation
thomas-robinson
requested changes
Apr 10, 2023
| end function get_diag_fields_entries | ||
|
|
||
| !> @brief Gets the output buffer ids corresponding to the indices in the sorted variable_list | ||
| !! @return Array of indices of the output buffers |
Member
There was a problem hiding this comment.
This should say "A copy of the array of indices of the output buffers"
Contributor
Author
There was a problem hiding this comment.
I want to change the name of the function to 'get_diag_field_ids'. What do you think?
uramirez8707
requested changes
Apr 10, 2023
|
|
||
| !> @brief Gets the output buffer ids corresponding to the indices in the sorted variable_list | ||
| !! @return Array of indices of the output buffers | ||
| function get_output_buffer_ids(indices) result(buffer_ids) |
Contributor
There was a problem hiding this comment.
The name of this function is misleading. This returns the indices of the field in the diag_yaml%diag_fields object. It is not related to the buffer ids.
FMS/diag_manager/fms_diag_yaml.F90
Line 228 in b9b2103
Contributor
Author
There was a problem hiding this comment.
I think the right name of the function should be something like 'get_diag_field_ids'. Do you agree?
Change get_output_buffer_ids to get_diag_field_ids and update comments.
Update comment
Replace buffer_ids with field_ids.
thomas-robinson
requested changes
Apr 19, 2023
| end function get_diag_fields_entries | ||
|
|
||
| !> @brief Gets field indices corresponding to the indices (input argument) in the sorted variable_list | ||
| !! @return Array of field indices |
Member
There was a problem hiding this comment.
This should say "Copy of array of field indices"
uramirez8707
approved these changes
Apr 19, 2023
8 tasks
Update comment for return
thomas-robinson
approved these changes
Apr 25, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Adds routine get_diag_field_ids
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Adds routine get_diag_field_ids
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds routine get_diag_field_ids to fms_diag_yaml_mod which gets indices of fields corresponding to indices in the sorted variable_list.
Fixes # (issue)
CI
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses