Skip to content

rename to add output to buffer names#1184

Merged
rem1776 merged 4 commits into
NOAA-GFDL:dmUpdatefrom
rem1776:buff_rename
Apr 6, 2023
Merged

rename to add output to buffer names#1184
rem1776 merged 4 commits into
NOAA-GFDL:dmUpdatefrom
rem1776:buff_rename

Conversation

@rem1776
Copy link
Copy Markdown
Contributor

@rem1776 rem1776 commented Apr 6, 2023

Description
renames to make more sense

only did the first two subroutines in the buffer object, didn't think it needed it for everything

How Has This Been Tested?
amd oneapi

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

class(fmsDiagFileContainer_type), allocatable :: FMS_diag_files (:) !< array of diag files
class(fmsDiagField_type), allocatable :: FMS_diag_fields(:) !< Array of diag fields
type(fmsDiagBufferContainer_type), allocatable :: FMS_diag_buffers(:) !< array of buffer objects
type(fmsDiagOutputBufferContainer_type), allocatable :: FMS_diag_output_buffers(:) !< array of output buffer objects
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one for each variable in the diag_table.yaml

@rem1776 rem1776 merged commit 45e1fd0 into NOAA-GFDL:dmUpdate Apr 6, 2023
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants