Modern diag_manager: add diurnal axis#1138
Merged
thomas-robinson merged 14 commits intoMar 7, 2023
Merged
Conversation
…to use when setting filename
thomas-robinson
requested changes
Mar 7, 2023
|
|
||
| dim_name(1) = this%axis_name | ||
| call register_axis(fileobj, this%axis_name, size(this%diurnal_data)) | ||
| call register_field(fileobj, this%axis_name, pack_size_str, dim_name) |
Member
There was a problem hiding this comment.
I don't think you need dim_name. You should be able to do
call register_field(fileobj, this%axis_name, pack_size_str, (/this%axis_name/))
Contributor
Author
There was a problem hiding this comment.
lol just testing you
| varlist: | ||
| - module: ocn_mod | ||
| var_name: var1 | ||
| reduction: diurnal12 |
thomas-robinson
approved these changes
Mar 7, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add the diurnal axis
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add the diurnal axis
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defines a new type of axis for the diurnal axis
Writes out the diurnal axis metadata and data
Adds a test for it
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses