Test priority labeling for PR Project board

.github/pull_request_template.md

@@ -15,7 +15,7 @@
 - [ ] All subcomponent pull requests (if any) have been reviewed by their code managers.
 - [ ] Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). **Exceptions:** documentation-only PRs, CI-only PRs, etc.
    - [ ] Commit log file w/full results from RT suite run (if applicable).
-   - [ ] Commit 'test_changes.list' (unless file is empty). 
+   - [ ] Verify that `test_changes.list` indicates which tests, if any, are changed by this PR. Commit `test_changes.list`, even if it is empty.
 - [ ] Fill out all sections of this template.
 
 ---
@@ -68,7 +68,7 @@ Add the related UFS WM Github Issue here:
 <!--
 Provide a list of subcomponents involved with this PR and include links to subcomponent PRs.
 Example:
-* FV3: NOAA-EMC/fv3atm#734
+* UFSATM: NOAA-EMC/UFSATM#734
   * ccpp-physics: ufs-community/ccpp-physics#33
 * WW3: NOAA-EMC/WW3#321
 Delete sections that are not needed.
@@ -78,7 +78,7 @@ Delete sections that are not needed.
 * CICE:
 * CMEPS:
 * CMakeModules:
-* FV3:
+* UFSATM:
   * ccpp-physics:
   * atmos_cubed_sphere:
 * GOCART:

.github/workflows/Spack.yml

@@ -0,0 +1,75 @@
+# This is a CI workflow for the ufs-weather-model repository that builds the
+# modified UWM in a given PR with Spack.
+#
+# Alex Richert, Mar 2025
+
+name: Spack
+on: [push,pull_request,workflow_dispatch]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  Spack:
+    strategy:
+      matrix:
+        # See ci/package.py for variant definitions.
+        config:
+        - {
+            os: "ubuntu-24.04",
+            app: "S2SWA",
+            ccpp_suites: "FV3_GFS_v17_coupled_p8,FV3_GFS_v17_coupled_p8_ugwpv1",
+            other-variants: ' ^esmf@8.8.0',
+          }
+        - {
+            os: "ubuntu-24.04",
+            app: "ATM",
+            ccpp_suites: "FV3_GFS_v16,FV3_GFS_v16_flake,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v17_p8_ugwpv1",
+            other-variants: ' ^esmf@8.8.0',
+          }
+
+    runs-on: ${{ matrix.config.os }}
+    permissions:
+      # For repo-level build caching by NOAA-EMC/ci-test-spack-package action
+      actions: write
+
+    steps:
+
+    - name: "Install dependencies with APT"
+      shell: bash
+      run: |
+        sudo mv /usr/local /usr/local_mv # relocate so CMake doesn't pick up on bad libraries
+        sudo apt install libopenmpi-dev openmpi-bin cmake
+
+    - name: "Build Spack package"
+      uses: NOAA-EMC/ci-test-spack-package@develop
+      with:
+        package-name: ufs-weather-model
+        # ufs-weather-model Spack recipe variants, plus additional package constraints:
+        package-variants: app=${{ matrix.config.app }} ccpp_suites=${{ matrix.config.ccpp_suites }} ${{ matrix.config.other-variants }}
+        custom-recipe: ci/package.py
+        spack-compiler: gcc@13
+        spack-test-flag: '' # disable 'make test' for Spack
+        use-common-build-cache: true
+        repo-cache-key-suffix: ${{ matrix.config.os }}-1 # Update to create and use a fresh cache
+        save-repo-cache: ${{ matrix.config.app == 'S2SWA' }} # Only need to save cache from one job
+        # Set to save to a different cache key than the restored one (in order to add new packages etc.).
+        #  Be sure to unset it after a new cache is generated or a new one will be created each time!
+        repo-save-key-suffix: ''
+
+  # The recipe-check job validates the Spack recipe by making sure each CMake
+  # build option is represented. If this check fails due to the addition of a
+  # new CMake option, ci/package.py should be updated in order to make that
+  # new build option configurable through Spack.
+  recipe-check:
+
+    runs-on: ubuntu-24.04
+
+    steps:
+
+    - name: recipe-check
+      uses: NOAA-EMC/ci-check-spack-recipe@develop
+      with:
+        recipe-file: package/spack/package.py
+        cmakelists-txt: package/CMakeLists.txt

.github/workflows/add_pr_to_project.yaml

@@ -14,8 +14,17 @@ jobs:
       pull-requests: write
       issues: write
     steps:
-      - uses: actions/add-to-project@v1.0.2
+      - name: Add PR
+        uses: actions/add-to-project@v1.0.2
         with:
           #project-url: https://github.com/orgs/ufs-community/projects/70
           project-url: https://github.com/orgs/NOAA-EPIC/projects/18
           github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+      - name: Add date created
+        uses: nipe0324/update-project-v2-item-field@v2.0.2
+        with:
+          #project-url: https://github.com/orgs/ufs-community/projects/70
+          project-url: https://github.com/orgs/NOAA-EPIC/projects/18
+          github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+          field-name: 'Date Opened'
+          field-value: ${{ github.event.pull_request.created_at }}

.github/workflows/superlinter.yml

@@ -27,7 +27,7 @@ jobs:
           LINTER_RULES_PATH: '.github/linters/'
           DEFAULT_BRANCH: origin/develop
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          FILTER_REGEX_EXCLUDE: .*(tests/fv3_conf/.*|tests/ci/.*|tests/auto/.*|tests/auto-jenkins/.*|tests/opnReqTests/.*|tests/opnReqTest|tests/atparse.bash).*
+          FILTER_REGEX_EXCLUDE: .*(tests/fv3_conf/.*|tests/ci/.*|tests/auto/.*|tests/auto-jenkins/.*|tests/opnReqTests/.*|tests/opnReqTest|tests/atparse.bash|ci/package.py).*
           VALIDATE_BASH: true
           BASH_SEVERITY: style
           #VALIDATE_GITHUB_ACTIONS: true

.github/workflows/update_project_labels.yaml

@@ -90,3 +90,70 @@ jobs:
           github-token: ${{ secrets.PR_PROJECT_TOKEN }}
           field-name: "Input Data Req'd"
           field-value: 'No'
+  priority-labels:
+    name: Priority
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+      issues: write
+    env:
+      PRIORITY: ''
+    steps:
+      - name: Read Priority field
+        uses: EndBug/project-fields@v2.1.0
+        id: priority_field
+        with:
+          operation: get
+          fields: Priority
+          github_token: ${{ secrets.PR_PROJECT_TOKEN }}
+          #project_url: https://github.com/orgs/ufs-community/projects/70
+          project_url: https://github.com/orgs/NOAA-EPIC/projects/18
+          resource_url: ${{ github.event.pull_request.html_url }}
+      - name: Assign value to Priority field
+        run: |
+          priority="${{ steps.priority_field.outputs.values }}"
+          echo "PRIORITY=$priority" >> $GITHUB_ENV
+          echo $PRIORITY
+          echo $( [ $PRIORITY != 'Combine' ] )
+      - name: Normal Priority
+        if: |
+            !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') &&
+            !contains(github.event.pull_request.labels.*.name, 'Priority: High') &&
+            ${{ env.PRIORITY != 'Combine' }}
+        uses: nipe0324/update-project-v2-item-field@v2.0.2
+        with:
+          #project-url: https://github.com/orgs/ufs-community/projects/70
+          project-url: https://github.com/orgs/NOAA-EPIC/projects/18
+          github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+          field-name: 'Priority'
+          field-value: 'Normal'
+      - name: Critical priority
+        if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')"
+        uses: nipe0324/update-project-v2-item-field@v2.0.2
+        with:
+          #project-url: https://github.com/orgs/ufs-community/projects/70
+          project-url: https://github.com/orgs/NOAA-EPIC/projects/18
+          github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+          field-name: 'Priority'
+          field-value: 'Critical'
+      - name: High Priority
+        if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))"
+        uses: nipe0324/update-project-v2-item-field@v2.0.2
+        with:
+          #project-url: https://github.com/orgs/ufs-community/projects/70
+          project-url: https://github.com/orgs/NOAA-EPIC/projects/18
+          github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+          field-name: 'Priority'
+          field-value: 'High'
+      - name: Unknown Priority
+        if: |
+            contains(github.event.pull_request.labels.*.name, 'Priority: Critical') &&
+            contains(github.event.pull_request.labels.*.name, 'Priority: High')
+        uses: nipe0324/update-project-v2-item-field@v2.0.2
+        with:
+          #project-url: https://github.com/orgs/ufs-community/projects/70
+          project-url: https://github.com/orgs/NOAA-EPIC/projects/18
+          github-token: ${{ secrets.PR_PROJECT_TOKEN }}
+          field-name: 'Priority'
+          field-value: 'Unknown'

CMakeLists.txt

@@ -64,6 +64,7 @@ message("FIRE_BEHAVIOR .... ${FIRE_BEHAVIOR}")
 ###############################################################################
 set(32BIT           OFF CACHE BOOL "Enable 32BIT (single precision arithmetic in dycore and fast physics)")
 set(CCPP_32BIT      OFF CACHE BOOL "Enable CCPP_32BIT (single precision arithmetic in slow physics)")
+set(RRTMGP_32BIT    OFF CACHE BOOL "Enable 32BIT (single precision arithmetic in rte-rrtmgp radiation)")
 set(AVX2            ON  CACHE BOOL "Enable AVX2 instruction set")
 set(AVX             OFF CACHE BOOL "Enable AVX-I instruction set")
 set(SIMDMULTIARCH   OFF CACHE BOOL "Enable multi-target SIMD instruction sets")
@@ -118,6 +119,7 @@ endif()
 message("")
 message("32BIT ............ ${32BIT}")
 message("CCPP_32BIT ....... ${CCPP_32BIT}")
+message("RRTMGP_32BIT ..... ${RRTMGP_32BIT}")
 message("AVX2 ............. ${AVX2}")
 message("SIMDMULTIARCH .... ${SIMDMULTIARCH}")
 message("DEBUG ............ ${DEBUG}")

ci/README

@@ -0,0 +1,3 @@
+This directory contains package.py, a local copy of the ufs-weather-model Spack recipe: https://github.com/spack/spack-packages/blob/develop/repos/spack_repo/builtin/packages/ufs_weather_model/package.py
+
+It will not need frequent updates, but it is used by the GitHub Actions workflow under .github/workflows/Spack.yml. It only needs updates for changes to minimum version requirements, new dependencies, and new build options. In package.py, `depends_on("esmf@8.8.0:", when="@develop")` for example means that the minimum version that Spack will consider using for UFS Weather Model's ESMF dependency is 8.8.0. These minimum versions should generally track with what is in CMakeLists.txt, though in practice, Spack will typically attempt to use the most recent release of a package available in that package's recipe.