Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
219dd7e
fix acronym
gspetro-NOAA Sep 28, 2025
bde5f6f
chg pull_request_target labels to pull_request
gspetro-NOAA Sep 28, 2025
dc9450b
add pull_request_target for labels
gspetro-NOAA Sep 28, 2025
a940bb1
change task names
gspetro-NOAA Sep 28, 2025
4d619c4
change task names
gspetro-NOAA Sep 28, 2025
e296f58
Merge branch 'feature/pr-management' into feature/add-labels
gspetro-NOAA Sep 28, 2025
63640dd
rename tasks; rm pull_request (no target)
gspetro-NOAA Sep 28, 2025
e03930c
clarify PR template language around test_changes.list
gspetro-NOAA Sep 28, 2025
6eb07b7
chg data in to pull_request from pr target
gspetro-NOAA Sep 28, 2025
a2bb75a
chg to pull_request from pr target
gspetro-NOAA Sep 28, 2025
b5421fe
fix critical priority
gspetro-NOAA Sep 29, 2025
658f60a
fix parentheses?
gspetro-NOAA Sep 29, 2025
2865a96
add quotes for BL labels
gspetro-NOAA Sep 29, 2025
0d0caa4
fix spaces
gspetro-NOAA Sep 29, 2025
44af740
rm extraneous quotes
gspetro-NOAA Sep 29, 2025
8fc40b7
fix whitespace
gspetro-NOAA Sep 29, 2025
d0267a6
remove labeled for add PR to project
gspetro-NOAA Sep 29, 2025
414fe28
rename file
gspetro-NOAA Sep 29, 2025
02f245d
address combinability for priority
gspetro-NOAA Sep 29, 2025
72d05e0
get priority field
gspetro-NOAA Sep 29, 2025
14e6521
rm extra -
gspetro-NOAA Sep 29, 2025
487c964
properly assign
gspetro-NOAA Sep 29, 2025
ed2f680
properly assign
gspetro-NOAA Sep 29, 2025
493b3ab
properly assign
gspetro-NOAA Sep 29, 2025
ac3287b
access
gspetro-NOAA Sep 29, 2025
6ca0294
fix project/resource url
gspetro-NOAA Sep 29, 2025
539dfb9
fix typo
gspetro-NOAA Sep 29, 2025
f7918e6
echo priority
gspetro-NOAA Sep 29, 2025
135c7a1
access
gspetro-NOAA Sep 29, 2025
5fdd223
test syntax
gspetro-NOAA Sep 29, 2025
7ebad44
test combinability
gspetro-NOAA Sep 29, 2025
d6003df
add test echo
gspetro-NOAA Sep 29, 2025
c0130cf
rm normal priority logic
gspetro-NOAA Sep 29, 2025
761e86f
remove priority label logic
gspetro-NOAA Sep 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- [ ] All subcomponent pull requests (if any) have been reviewed by their code managers.
- [ ] Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). **Exceptions:** documentation-only PRs, CI-only PRs, etc.
- [ ] Commit log file w/full results from RT suite run (if applicable).
- [ ] Commit 'test_changes.list' (unless file is empty).
- [ ] Verify that 'test_changes.list' indicates which tests, if any, are changed by this PR. If needed, commit the updated 'test_changes.list' file.
- [ ] Fill out all sections of this template.

---
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/add_pr_to_project.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
types:
- opened
- reopened
- labeled

jobs:
add-to-project:
Expand Down
80 changes: 7 additions & 73 deletions .github/workflows/update_project_labels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
baseline-labels:
name: Update project with baseline labels
name: Baseline labels
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -19,7 +19,7 @@ jobs:
- name: Lack of baseline labels
if: |
!contains(github.event.pull_request.labels.*.name, 'No Baseline Change') &&
!contains(github.event.pull_request.labels.*.name, 'Baseline Updates') &&
!contains(github.event.pull_request.labels.*.name, 'Baseline Updates') &&
!contains(github.event.pull_request.labels.*.name, 'New Baselines')
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
Expand All @@ -31,7 +31,7 @@ jobs:
- name: Contradictory labels
if: |
contains(github.event.pull_request.labels.*.name, 'No Baseline Change') &&
(contains(github.event.pull_request.labels.*.name, 'Baseline Updates') ||
(contains(github.event.pull_request.labels.*.name, 'Baseline Updates') ||
contains(github.event.pull_request.labels.*.name, 'New Baselines'))
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
Expand All @@ -42,9 +42,9 @@ jobs:
field-value: 'Unknown'
- name: Baseline changes labels
if: |
(contains(github.event.pull_request.labels.*.name, 'Baseline Updates') ||
contains(github.event.pull_request.labels.*.name, 'New Baselines')) &&
!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')
!contains(github.event.pull_request.labels.*.name, 'No Baseline Change') &&
( contains(github.event.pull_request.labels.*.name, 'Baseline Updates') ||
contains(github.event.pull_request.labels.*.name, 'New Baselines') )
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
#project-url: https://github.com/orgs/ufs-community/projects/70
Expand All @@ -65,7 +65,7 @@ jobs:
field-name: 'Baseline Changes'
field-value: 'No'
data-labels:
name: Update project with input data labels
name: Input data
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -90,69 +90,3 @@ jobs:
github-token: ${{ secrets.PR_PROJECT_TOKEN }}
field-name: "Input Data Req'd"
field-value: 'No'
#Figure out "Combine" toggle & logic
priority-labels:
name: Update project with priority labels
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
issues: write
steps:
- name: Normal Priority
if: |
!contains(github.event.pull_request.labels.*.name, 'Priority: Critical') &&
!contains(github.event.pull_request.labels.*.name, 'Priority: High')
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
#project-url: https://github.com/orgs/ufs-community/projects/70
project-url: https://github.com/orgs/NOAA-EPIC/projects/18
github-token: ${{ secrets.PR_PROJECT_TOKEN }}
field-name: 'Priority'
field-value: 'Normal'
- name: Critical priority
if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')"
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
#project-url: https://github.com/orgs/ufs-community/projects/70
project-url: https://github.com/orgs/NOAA-EPIC/projects/18
github-token: ${{ secrets.PR_PROJECT_TOKEN }}
field-name: 'Priority'
field-value: 'Yes'
- name: High Priority
if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))"
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
#project-url: https://github.com/orgs/ufs-community/projects/70
project-url: https://github.com/orgs/NOAA-EPIC/projects/18
github-token: ${{ secrets.PR_PROJECT_TOKEN }}
field-name: 'Priority'
field-value: 'High'
- name: Unknown Priority
if: |
contains(github.event.pull_request.labels.*.name, 'Priority: Critical') &&
contains(github.event.pull_request.labels.*.name, 'Priority: High')
uses: nipe0324/update-project-v2-item-field@v2.0.2
with:
#project-url: https://github.com/orgs/ufs-community/projects/70
project-url: https://github.com/orgs/NOAA-EPIC/projects/18
github-token: ${{ secrets.PR_PROJECT_TOKEN }}
field-name: 'Priority'
field-value: 'Unknown'
subcomponent-labels:
name: Update project with input data labels
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
issues: write
steps:
- name: TBD
#if: (contains(github.event.pull_request.labels.*.name, 'Priority: High'))
#uses: nipe0324/update-project-v2-item-field@v2.0.2
#with:
#project-url: https://github.com/orgs/ufs-community/projects/70
#project-url: https://github.com/orgs/NOAA-EPIC/projects/18
#github-token: ${{ secrets.PR_PROJECT_TOKEN }}
#field-name: 'Baseline Changes'
#field-value: 'Yes'
142 changes: 0 additions & 142 deletions .github/workflows/update_project_labels_target.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion doc/UsersGuide/source/Acronyms.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Acronyms
+----------------+---------------------------------------------------+
| GFS | Global Forecast System |
+----------------+---------------------------------------------------+
| GSD | Global Systems Division |
| GSL | Global Systems Laboratory |
+----------------+---------------------------------------------------+
| HTML | Hypertext Markup Language |
+----------------+---------------------------------------------------+
Expand Down