Add 'file_version' global attribute to sfc_data restart files#997
Conversation
|
I've opened the SFS PR which requires this feature and this PR is bundled in. At the same time, I'm also fixing the ultralow configurations which also require the V2 attribute in the warmstart/restart files. |
|
Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2835? |
|
@DusanJovic-NOAA Can you sync up so I can run the final tests on ufs-community/ufs-weather-model#2835 |
Done |
|
@junwang-noaa Can you review ? Thanks. |
|
@DusanJovic-NOAA Can you please update your branch? Thx. |
Done. |
|
@DusanJovic-NOAA Would you please update this branch w/ the most recent UPP hash so I can see if it fixes the debug failure for the new SFS test? |
Done. |
|
@DusanJovic-NOAA Do you want to combine #1030 into here so post interface works again? |
I merged your branch, please double check. |
|
Looks good. The ci/cd should pass now |
|
@DusanJovic-NOAA Please sync; the SFS RT PR is next up. |
Done. |
|
Testing on #2835 is complete, please continue with merging, thank you. |
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
This PR adds 'file_version' global attribute to sfc_data restart files, as defined in input sfc_data files. This is needed in order to have bit-identical restarts when the model is initialized with version 2 surface data files. See ufs-community/ufs-weather-model#2827
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? ufs-weather-model regression tests
What compilers / HPCs was it tested with? Intel/GNU on Ursa
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes. On what platform? Ursa
Dependencies
Do PRs in upstream repositories need to be merged first? No