Skip to content

Add 'file_version' global attribute to sfc_data restart files#997

Merged
jkbk2004 merged 18 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:sfc_v2_att
Nov 10, 2025
Merged

Add 'file_version' global attribute to sfc_data restart files#997
jkbk2004 merged 18 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:sfc_v2_att

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

This PR adds 'file_version' global attribute to sfc_data restart files, as defined in input sfc_data files. This is needed in order to have bit-identical restarts when the model is initialized with version 2 surface data files. See ufs-community/ufs-weather-model#2827

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? ufs-weather-model regression tests
What compilers / HPCs was it tested with? Intel/GNU on Ursa
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes. On what platform? Ursa

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

Do PRs in upstream repositories need to be merged first? No

Comment thread ccpp/data/GFS_typedefs.F90 Outdated
Comment thread fv3/io/fv3atm_restart_io.F90
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

I've opened the SFS PR which requires this feature and this PR is bundled in. At the same time, I'm also fixing the ultralow configurations which also require the V2 attribute in the warmstart/restart files.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2835?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Can you sync up so I can run the final tests on ufs-community/ufs-weather-model#2835

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Can you sync up so I can run the final tests on ufs-community/ufs-weather-model#2835

Done

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@junwang-noaa Can you review ? Thanks.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Can you please update your branch? Thx.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Can you please update your branch? Thx.

Done.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Would you please update this branch w/ the most recent UPP hash so I can see if it fixes the debug failure for the new SFS test?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Would you please update this branch w/ the most recent UPP hash so I can see if it fixes the debug failure for the new SFS test?

Done.

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Do you want to combine #1030 into here so post interface works again?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Do you want to combine #1030 into here so post interface works again?

I merged your branch, please double check.

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator

Looks good. The ci/cd should pass now

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Please sync; the SFS RT PR is next up.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Please sync; the SFS RT PR is next up.

Done.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Testing on #2835 is complete, please continue with merging, thank you.

@jkbk2004 jkbk2004 merged commit b667c11 into NOAA-EMC:develop Nov 10, 2025
8 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the sfc_v2_att branch November 17, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restart outputs are not b4b identical to cold-start run when sfc v2 files are used

8 participants