Skip to content

Fix zero out accumulated total precip #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junwang-noaa wants to merge 6 commits into from
Closed

Fix zero out accumulated total precip #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc7b73e
fix zero out accumulated total precip
junwang-noaa Jun 9, 2025
6a180d0
add a print line
junwang-noaa Jun 9, 2025
4741e65
set iauwindow_center default value
junwang-noaa Jun 9, 2025
532a2af
accumulation time change
junwang-noaa Jun 18, 2025
95b3d95
prints
junwang-noaa Jun 18, 2025
6e6ea30
remove if statement
junwang-noaa Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ccpp/CCPP_driver.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ subroutine CCPP_step (step, nblks, ierr)
! Local variables
integer :: nb, nt, ntX
integer :: ierr2
integer :: kdt_iau
logical :: iauwindow_center
! DH* 20210104 - remove kdt_rad when code to clear diagnostic buckets is removed
integer :: kdt_rad

Expand Down Expand Up @@ -167,8 +169,17 @@ subroutine CCPP_step (step, nblks, ierr)
endif

!--- determine if physics diagnostics buckets need to be cleared
iauwindow_center = .false.
if (GFS_control%iau_offset > 0) then
kdt_iau = nint(GFS_control%iau_offset*3600./GFS_control%dtp)
if (GFS_control%kdt-1 == kdt_iau) then
iauwindow_center = .true.
if( GFS_control%me == 0)print *,'in ccpp step vary, iauwindow_center=',iauwindow_center,&
'kdt=',GFS_control%kdt,'dtp=',GFS_control%dtp,'iau_offset=',GFS_control%iau_offset
endif
endif
if ((mod(GFS_control%kdt-1,GFS_control%nszero)) == 0) then
call GFS_Intdiag%phys_zero(GFS_control)
call GFS_Intdiag%phys_zero(GFS_control, iauwindow_center=iauwindow_center)
Comment thread
DusanJovic-NOAA marked this conversation as resolved.
endif

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Expand Down
12 changes: 3 additions & 9 deletions fv3/atmos_model.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,24 +1001,18 @@ subroutine update_atmos_model_state (Atmos, rc)
call get_time (Atmos%Time - Atmos%Time_init, seconds)
call atmosphere_nggps_diag(Atmos%Time,ltavg=.true.,avg_max_length=avg_max_length)
if (ANY(nint(output_fh(:)*3600.0) == seconds) .or. (GFS_control%kdt == first_kdt)) then
if (mpp_pe() == mpp_root_pe()) write(6,*) "---isec,seconds",isec,seconds
time_int = real(isec)
time_intfull = real(seconds)
if(Atmos%iau_offset > zero) then
if( time_int - Atmos%iau_offset*3600. > zero ) then
time_int = time_int - Atmos%iau_offset*3600.
else if(seconds == Atmos%iau_offset*3600) then
call get_time (Atmos%Time - diag_time_fhzero, isec_fhzero)
time_int = real(isec_fhzero)
if (mpp_pe() == mpp_root_pe()) write(6,*) "---iseczero",isec_fhzero
endif
endif
time_intfull = real(seconds)
if(Atmos%iau_offset > zero) then
if( time_intfull - Atmos%iau_offset*3600. > zero) then
time_intfull = time_intfull - Atmos%iau_offset*3600.
endif
endif
if (mpp_pe() == mpp_root_pe()) write(6,*) ' gfs diags time since last bucket empty: ',time_int/3600.,'hrs'
if (mpp_pe() == mpp_root_pe()) write(6,*) 'gfs diags time since last bucket empty: ',time_int,' time_intfull=', &
time_intfull,' kdt=',GFS_control%kdt
call atmosphere_nggps_diag(Atmos%Time)
call fv3atm_diag_output(Atmos%Time, GFS_Diag, Atm_block, GFS_control%nx, GFS_control%ny, &
GFS_control%levs, 1, 1, 1.0_GFS_kind_phys, time_int, time_intfull, &
Expand Down
6 changes: 1 addition & 5 deletions fv3/fv3_cap.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,11 +949,7 @@ subroutine InitializeAdvertise(gcomp, rc)
if( nfhmax>output_startfh) nfh = nint((nfhmax-output_startfh)/outputfh2(1)) + 1
if( nfh > 0) then
allocate(output_fh(nfh))
if( output_startfh == 0) then
output_fh(1) = dt_atmos/3600.
else
output_fh(1) = output_startfh
endif
output_fh(1) = output_startfh + dt_atmos/3600.
do i=2,nfh
output_fh(i) = (i-1)*outputfh2(1) + output_startfh
! Except fh000, which is the first time output, if any other of the
Expand Down
Loading