Modify FV3 code for unit testing#966
Merged
jkbk2004 merged 17 commits intoJul 9, 2025
Merged
Conversation
This was referenced May 15, 2025
Closed
Closed
Collaborator
Author
AlexanderRichert-NOAA
approved these changes
Jun 16, 2025
Contributor
AlexanderRichert-NOAA
left a comment
There was a problem hiding this comment.
This looks good to me, and it's great to see a batch of new unit tests. The only suggestion I'd offer would be to add error messages before the 'stop' calls in the unit tests if you thought it would facilitate investigating failed tests.
DusanJovic-NOAA
approved these changes
Jun 16, 2025
Collaborator
Author
|
Went ahead and added some error messages to the tests. I'll start getting the PR up on the UFS side. |
13 tasks
This was referenced Jun 26, 2025
13 tasks
jkbk2004
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR is now a combination of other PRs. This includes the following:
./tests/directory.These three PRs are working towards the similar goal, so they were combined so it can be more easily and quickly added to the UFS repo.
There are additional tests in my fix/cicd branch for subroutines in the moving nest folder, but I believe this requires more work to the CI/CD workflow. There are other tests that will also require some dummy data for unit testing.
This PR will be the first batch of tests that can be added to FV3 with other tests added in the near future.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Using the UFS RT suite
What compilers / HPCs was it tested with? Tests were done on Hera
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform? Yes, Hera
Dependencies
Do PRs in upstream repositories need to be merged first? No