Bug fix for surface roughness calculation over lakes and sea ice points when wave model is turned on#964
Merged
Conversation
added 2 commits
May 13, 2025 08:41
…on of surface roughness length over lake and ice points in ccpp/physics
13 tasks
jkbk2004
approved these changes
May 28, 2025
Contributor
|
@ChristianBoyer-NOAA ufs-community/ccpp-physics#281 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@9ae08ca) and revert the .gitmodules file in preparation for the merge. |
DusanJovic-NOAA
approved these changes
Jun 2, 2025
BrianCurtis-NOAA
approved these changes
Jun 2, 2025
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a bug fix so that the wave model only updates surface roughness over open ocean, and not over lakes and sea ice. It also avoids using unrealistic surface roughness values from the wave model, such as values greater than 0.1 m.
Issue(s) addressed
Testing
Simulations were conducted on Hercules at C1152 resolution.
Regressions tests were performed on Hercules and the log files are committed in the ufs-weather-model branch.
Additionally, a new baseline was created and the results were reproduced when compared to its new baseline.
Dependencies