Use ESMF Redist instead of Remap for history bundles with 'cubed_sphere_grid' output grid#929
Merged
Merged
Conversation
…e_grid' output grid.
14 tasks
* Debugging log around RH creation. * Log the fcstItemNameList(j) when looping over RH creation... which contains info on regrid method. * Cleanup to be generally usable code.
jkbk2004
approved these changes
Apr 3, 2025
Collaborator
|
Tests are done at ufs-community/ufs-weather-model#2595. We can merge this pr. |
FernandoAndrade-NOAA
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in the write grid component where regional cubed sphere output have undefined (zero) values on some points on the edge (outermost rows and columns). This happens only when model is compiled with -D32BIT=ON option due to round off differences in lat/lon grid coordinate values between forecast and write grid component. When model is compiled without -D32BIT=ON, both forecast and write grid components use 64bit values for grid coordinates and in that case during the remapping all grid points are defined (i.e. 'inside the model domain'). Solution is to use ESMF Redist instead of Remap for all cubed sphere grid outputs.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Yes. UFS regression test, and Arctic domain test as reported in ufs-community/ufs-weather-model#2589
What compilers / HPCs was it tested with? Intel and GNU on Hercules.
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes. On what platform? Hercules
Dependencies
No.