Skip to content

Land surface upgrades for HR4#855

Merged
jkbk2004 merged 8 commits into
NOAA-EMC:developfrom
HelinWei-NOAA:land_upgrade_hr4
Jul 23, 2024
Merged

Land surface upgrades for HR4#855
jkbk2004 merged 8 commits into
NOAA-EMC:developfrom
HelinWei-NOAA:land_upgrade_hr4

Conversation

@HelinWei-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR mainly involves changes in ccpp-physics

To address some concerns from HR3 especially the surface cold biases we have finalized some land surface upgrades after carrying out extensive tests and evaluation.

  • remove vegetation type-dependent for the diagnostic option (opt_diag) used in HR3
  • use radiative temperature as skin temperature
  • use single loop alternative approach to address some flux inconsistence below and above the canopy
  • fix the thermal roughness bug (the one for bared portion in the composition is not the same as the one used in the bared title)
  • adjust some momentum roughness length
  • use the interpolated temp between the skin temp and the first soil temp to get the initial snow temp based on snow depth
  • use constant snow thermal conductivity to reduce the snow insulation effects
  • fix radiation parameter bugs for grassland/cropland
  • adjust albedo parameter for each soil color category

This PR will change results on those suites using NoahMP

The changes have undergone extensive testing within the HR3 framework
The changes are covered by regression tests
the ufs-weather-model regression test has been run on wcoss2
the code updates will change regression test baseline

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on ufs-community/ccpp-physics PR #219

@grantfirl
Copy link
Copy Markdown
Collaborator

@HelinWei-NOAA @FernandoAndrade-NOAA ufs-community/ccpp-physics#219 was merged. This is ready to revert .gitmodules and update the ccpp/physics submodule pointer to: ufs-community/ccpp-physics@2a50ccc

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Ok, this should be ready to go. Please continue with merging.

@jkbk2004 jkbk2004 merged commit 927261d into NOAA-EMC:develop Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants