Skip to content

Coupled stochy fixes for precipitation#85

Closed
pjpegion wants to merge 5 commits into
NOAA-EMC:developfrom
pjpegion:coupled_stochy_fixes
Closed

Coupled stochy fixes for precipitation#85
pjpegion wants to merge 5 commits into
NOAA-EMC:developfrom
pjpegion:coupled_stochy_fixes

Conversation

@pjpegion
Copy link
Copy Markdown
Collaborator

The pull request references ufs-community/ufs-s2s-model#58, there was an inconsistency between the partition of the rain and snow and the rain/snow tendency that was later perturbed as part of SPPT.
The update to GFS_physics_driver.F90 makes these consistent.

@climbfuji
Copy link
Copy Markdown
Collaborator

I approved the corresponding ccpp-physics change. Merging will have to be coordinated with the ufs-weather-model commit queue.

@climbfuji
Copy link
Copy Markdown
Collaborator

Update 03/24/2020: this PR has been pulled into #86 and will be merged automatically as part of it. No need to close this PR, it will be flagged as merged automatically.

@climbfuji
Copy link
Copy Markdown
Collaborator

This PR was merged as part of #86 - for some reason, it doesn't show up as "merged" automatically. Please double-check, but I think this PR can be closed.

@pjpegion
Copy link
Copy Markdown
Collaborator Author

pjpegion commented Mar 27, 2020 via email

@climbfuji
Copy link
Copy Markdown
Collaborator

Hi Dom, I see the updates are now in develop, the PR can be closed Thanks, Phil

Thanks! Importantly, the commits still show you as author, so you get the credit for doing the work (and not me for pulling them in).

@junwang-noaa
Copy link
Copy Markdown
Collaborator

PR #86 was committed, close this PR.

climbfuji pushed a commit to climbfuji/fv3atm that referenced this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants