Fix aux2d dim#833
Closed
drnimbusrain wants to merge 18 commits into
Closed
Conversation
Collaborator
|
I do not see corresponding ufs-weather-model PR. |
Contributor
Author
@DusanJovic-NOAA Where in the ufs-weather-model are corresponding changes needed for this bug fix? This is only a change for bugfix to fv3atm/ccpp/data/GFS_typedefs.meta. |
Collaborator
|
The ufs-weather-model PR is required to run regression tests. Or, if you want I can merge this change into one of my PRs. |
Contributor
Author
|
Ah, just updating the FV3 submodule hash in ufs-weather-model.
Yes, could you just merge it? Thanks!
…On Mon, Jul 8, 2024, 1:05 PM Dusan Jovic ***@***.***> wrote:
The ufs-weather-model PR is required to run regression tests. Or, if you
want I can merge this change into one of my PRs.
—
Reply to this email directly, view it on GitHub
<#833 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNTBS2OHX46NQ7E5VW3ZLLBFFAVCNFSM6AAAAABHUS63HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG4ZDGMRZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Merged with #856 |
Collaborator
|
Merged via #856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in dimension definition for the 2D auxiliary array.
This can only be identified if a user only wants to output 2D auxilarly arrays, and will face CCPP prebuild errors that clearly show the inconsistency.
This bug also exists in the CCPP auxiliary ReadTheDocs:
https://ccpp-techdoc.readthedocs.io/en/latest/ParamSpecificOutput.html#output-of-auxiliary-arrays-from-ccpp
Issue(s) addressed
#834
Testing
How were these changes tested?
RDHPCs Hera.
No changes to baseline and regression tests not performed.