Add option to specify history and inline post files output directory#826
Merged
Merged
Conversation
junwang-noaa
approved these changes
Apr 25, 2024
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Thanks for making the change, it looks good to me.
aerorahul
approved these changes
Apr 25, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Looks good.
Thank you for working on this so quickly.
Collaborator
Author
|
In order to fix the github workflow we need to update upp (see #819 (comment)). I am running test on Hercules and if there are no changes in the baselines I'll update the upp submodule. @WenMeng-NOAA |
Contributor
@DusanJovic-NOAA Your plan sounds good to me. There might be inline post result changes (grib2 files) with upp submodule update. |
14 tasks
Collaborator
jkbk2004
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What bug does it fix, or what feature does it add?
fv3atm_output_dir) to specify directory in which all history and inline post files will be saved instead of in the run directory.Is a change of answers expected from this PR? No.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
FV3ATM_OUTPUT/#822Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs