Skip to content

[production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics.#825

Merged
MatthewPyle-NOAA merged 4 commits into
NOAA-EMC:production/RRFS.v1from
dustinswales:production/RRFS.v1/swdnclrskyflx_diag
May 7, 2024
Merged

[production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics.#825
MatthewPyle-NOAA merged 4 commits into
NOAA-EMC:production/RRFS.v1from
dustinswales:production/RRFS.v1/swdnclrskyflx_diag

Conversation

@dustinswales
Copy link
Copy Markdown
Collaborator

Description

This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.
This is needed for RRFSv1.

Analogous to #824 into develop branch.

Issue(s) addressed

N/A

Testing

Tested on Hera using Intel compilers.
No change to results.

@MatthewPyle-NOAA MatthewPyle-NOAA changed the title Add clear-sky shortwave downward at surface flux to available diagnostics. [production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics. May 1, 2024
@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator

@dustinswales @EricJames-NOAA Are PRs coming for ccpp-physics and UFS WM to complete this one?

@EricJames-NOAA
Copy link
Copy Markdown

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator

Yes, @EricJames-NOAA - thanks. Just modified the titles to add the [production/RRFS.v1]

@grantfirl
Copy link
Copy Markdown
Collaborator

@dustinswales @MatthewPyle-NOAA ufs-community/ccpp-physics#198 is merged. This is ready to revert .gitmodules and update the ccpp-physics submodule pointer.

@jkbk2004 jkbk2004 requested a review from MatthewPyle-NOAA May 7, 2024 15:22
Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...approving

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit cf8d14d into NOAA-EMC:production/RRFS.v1 May 7, 2024
@dustinswales dustinswales deleted the production/RRFS.v1/swdnclrskyflx_diag branch January 6, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants