Skip to content

Thompson-Eidhammer microphysics code formatting#740

Closed
AndersJensen-NOAA wants to merge 2 commits into
NOAA-EMC:developfrom
AndersJensen-NOAA:thompson_refactor
Closed

Thompson-Eidhammer microphysics code formatting#740
AndersJensen-NOAA wants to merge 2 commits into
NOAA-EMC:developfrom
AndersJensen-NOAA:thompson_refactor

Conversation

@AndersJensen-NOAA
Copy link
Copy Markdown
Contributor

@AndersJensen-NOAA AndersJensen-NOAA commented Dec 19, 2023

This PR points to changes to Thompson-Eidhammer microphysics ->

This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.

This PR includes:

The addition of parameterized kind: REAL -> real(kind_phys)
Consistent indentation
Removal of GOTO statements


Description: Above
Issue(s) addressed: Formatting
Testing
How were these changes tested? The changes were tested on Hera.

What compilers / HPCs was it tested with? It was tested with Inte compilers on Hera.

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.

Have the ufs-weather-model regression test been run? On what platform? Yes, the ufs-weather-model regression test for P8 and RRFS been run on Hera.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No

Please commit the regression test log files in your ufs-weather-model branch

Dependencies
Do PRs in upstream repositories need to be merged first? No.

@grantfirl
Copy link
Copy Markdown
Collaborator

@jkbk2004 I think that this PR can be closed in favor of #790 that is targeted at the RRFS release branch. These changes WILL need to go into develop after they are in the release branch.

@jkbk2004
Copy link
Copy Markdown
Collaborator

closed to follow with #790

@jkbk2004 jkbk2004 closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants