Add option to use netcdf quantization#718
Merged
Merged
Conversation
42 tasks
BrianCurtis-NOAA
approved these changes
Nov 9, 2023
Collaborator
|
@DusanJovic-NOAA can we resolve the conversation and move on to merge the pr? |
jkbk2004
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new configuration parameters which can be used to enable the netcdf quantization (lossy compression)
Two new (optional) model_configure parameters are: quantize_mode, quantize_nsd. The
quantize_modeis a string which can have values 'quantize_bitgroom', 'quantize_granularbr' or 'quantize_bitround'., andquantize_nsdis number of significant digits. See documentation here.Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? UFSWM regression test.
What compilers / HPCs was it tested with? Intel and GNU on Hera
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes.
On what platform? Hera
Dependencies
N/A