Skip to content

Add option to use netcdf quantization#718

Merged
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:nc_quantize
Nov 27, 2023
Merged

Add option to use netcdf quantization#718
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:nc_quantize

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Description

This PR adds new configuration parameters which can be used to enable the netcdf quantization (lossy compression)
Two new (optional) model_configure parameters are: quantize_mode, quantize_nsd. The quantize_mode is a string which can have values 'quantize_bitgroom', 'quantize_granularbr' or 'quantize_bitround'., and quantize_nsd is number of significant digits. See documentation here.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? UFSWM regression test.
What compilers / HPCs was it tested with? Intel and GNU on Hera
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes.
On what platform? Hera

  • Will the code updates change regression test baseline? Yes. If yes, why? The quantization method is changes in two regression tests (control_wrtGauss_netcdf_parallel and control_wrtGauss_netcdf_parallel_debug).
  • Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch.

Dependencies

N/A

Comment thread io/module_write_netcdf.F90
@jkbk2004
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA can we resolve the conversation and move on to merge the pr?

@jkbk2004 jkbk2004 merged commit 65c6017 into NOAA-EMC:develop Nov 27, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the nc_quantize branch November 28, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transition to the build-in quantization capability in netcdf-c and clean up hard-coded quantization in fv3

4 participants