Skip to content

Add a condition to turn off samfdeepcnv when MYNN shallow convection active#714

Merged
jkbk2004 merged 6 commits into
NOAA-EMC:developfrom
XiaqiongZhou-NOAA:switch_sas
Nov 9, 2023
Merged

Add a condition to turn off samfdeepcnv when MYNN shallow convection active#714
jkbk2004 merged 6 commits into
NOAA-EMC:developfrom
XiaqiongZhou-NOAA:switch_sas

Conversation

@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor

Description

Add a switch to turn off samfdeepcnv when MYNN shallow convection active.
The answer will be changed if both SaSAS deep convection and MYNN schemes are used.

Testing

Tested on WCOSS2 and hera intel

Dependencies

ufs-community/ccpp-physics#121

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title Add a switch to turn off samfdeepcnv when MYNN shallow convection active Add a condition to turn off samfdeepcnv when MYNN shallow convection active Oct 20, 2023
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review October 20, 2023 17:01
@grantfirl
Copy link
Copy Markdown
Collaborator

@XiaqiongZhou-NOAA ufs-community/ccpp-physics#121 was merged. Please revert the changes to .gitmodules and point to the latest commit of the ufs/dev branch of ccpp/physics: ufs-community/ccpp-physics@c2ec9e5

@zach1221
Copy link
Copy Markdown
Collaborator

zach1221 commented Nov 9, 2023

@jkbk2004 we have approvals here. Feel free to merge.

@jkbk2004 jkbk2004 merged commit 36500b6 into NOAA-EMC:develop Nov 9, 2023
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants