Add zstandard compression#706
Merged
Merged
Conversation
junwang-noaa
approved these changes
Oct 4, 2023
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The changes are good, the code looks cleaner, thanks.
sadeghitabas
approved these changes
Oct 31, 2023
sadeghitabas
approved these changes
Oct 31, 2023
jkbk2004
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
New model_configure configuration parameter has been added (zstandard_level). Valid values are 0-19 (default is 0). Value 0 turns off compression, values 1-19 specify the level of compression (1=fastest compression, 19=best compression ratio),
What bug does it fix, or what feature does it add? Add option to enable zstandard compression.
Is a change of answers expected from this PR? No.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Regression test on Hera and Acorn
What compilers / HPCs was it tested with? Inetl, GNU
Are the changes covered by regression tests? No. Currently
nccmpcan not compare netcdf files with zstandard compression enabled. The nccmp program needs to be updated.Have the ufs-weather-model regression test been run? Yes. On what platform? Hera