Support new NSSL cloud microphysics 3-moment option#702
Merged
Conversation
…into feature/nsslmicro
…e/nsslmicro-merge
… match allocation/use
Feature/nsslmicro merge gjf
…into feature/ideal-new
Included ccpp suite that turns off pbl and surface layer schemes for better idealized testing.
42 tasks
jkbk2004
requested review from
BrianCurtis-NOAA,
DusanJovic-NOAA and
jkbk2004
BrianCurtis-NOAA
approved these changes
Nov 2, 2023
DusanJovic-NOAA
approved these changes
Nov 2, 2023
Collaborator
|
@MicroTed ufs-community/ccpp-physics#110 is merged. Please revert .gitmodules and update the ccpp/physics submodule pointer to the latest ufs-dev commit: ufs-community/ccpp-physics@c751a5a |
Contributor
Author
|
@grantfirl Thanks! OK, it should be updated now. |
This was referenced Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds namelist flag (nssl_3moment) and tracer variables to use NSSL 3-moment microphysics option (3-moment for rain, graupel, and hail)
Issue(s) addressed
Supports PR for CCPP: ufs-community/ccpp-physics#110
Also initializes the fscav_aero array to nulls so that the logfile.out doesn't have random memory values and look like a binary file (and sometimes screw up xterm settings with random control codes when the file is viewed with more/less)
Testing
RT with ufs_model has been done on hera. Results change as expected for SDFs that use the NSSL scheme (FV3_rrfs_v1nssl and FV3_WoFS_v0). Also tested on MacOS (intel cpu;gfortran). Weather model branch with FV3/ccpp update is
https://github.com/MicroTed/ufs-weather-model/tree/feature-nssl3m
url= https://github.com/MicroTed/ufs-weather-model.git
branch=feature-nssl3m
RT does not include the 3-moment option, but I'm not sure one is really needed.
Have the ufs-weather-model regression test been run? On what platform?
Yes, it will change regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn because of some changes to the NSSL microphysics scheme that is used with the tests.
/scratch1/BMC/gsd-fv3-dev/Ted.Mansell/ufs/ufs-nssl3m/tests/RegressionTests_hera.log.nssl3m
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
url = https://github.com/MicroTed/ccpp-physics
branch = ufsdev-nssl3m
Concurrent PR for CCPP: ufs-community/ccpp-physics#110