Add run time info and upp

[junwang-noaa]

Description

This PR is to add run time info and using consistent missing value in fv3atm.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

• fixes Adding run time information for fv3 grid component #677
• fixes unify the filled_value in atmosphere history fiels ufs-community/ufs-weather-model#1031

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

• Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
• Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on noaa-emc/nems/pull/<pr_number>
• waiting on noaa-emc/fv3atm/pull/<pr_number>

[GeorgeVandenberghe-NOAA]

Do you have a sample printout? Would like to see this at restart write time.

Not a crippling error but it would be helpful to accumulate the run duration sum of timers - timere to look for spikes. This is how I found restart and history write spikes from various components.

[GeorgeVandenberghe-NOAA]

I should note the purpose of this PR is to provide better runtime timestep statistics, an excellent idea@

On Wednesday, July 5, 2023, Dusan Jovic ***@***.***> wrote: @DusanJovic-NOAA commented on this pull request. ________________________________ In fv3_cap.F90: >

!-----------------------------------------------------------------------------

rc = ESMF_SUCCESS + timep1rs = MPI_Wtime() + if(lprint) print *,'in fv3_cap,modeladvance phase1 time ',

timep1rs-timep2re,mype

Shouldn't this message be something like ' .. time between phase 2 and

phase 1' like in ModelAdvance? We are subtracting here start of this subroutine from the end of the previous time step phase 2.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.<

https://ci3.googleusercontent.com/proxy/LlJvHy_vgPRkUyK2Ua262198CtehAztT-WAn4ULUsyv9rCZKnGV6oW29xeiVmlZeyX989v274eJyPJ71dmEVIvfa8ZRfQDrWCjnxW0MJ8ZZ0iL2EzIEsO8YmMU5dyynZx13Ve29fpXbkJrQqWNdlW42lL_qczH4yWnrNZttKK-sfDqpM8TgUVxS7H7jdW2JP64G7e-WQqjCXYrfvQkgRTUGCr20SMP_OZlMiVV5za3r0yuvuHmTvapEKIKIX=s0-d-e1-ft#https://github.com/notifications/beacon/ANDS4FU57Z2RUCW6OM7Z4ITXOXFMVA5CNFSM6AAAAAAZ7NKJGKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS2KHSLS.gif>Message ID: ***@***.***>

…

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

[junwang-noaa]

Do you have a sample printout? Would like to see this at restart write time.

Not a crippling error but it would be helpful to accumulate the run duration sum of timers - timere to look for spikes. This is how I found restart and history write spikes from various components.

@GeorgeVandenberghe-NOAA You can see a test case at: /work/noaa/stmp/junwang/stmp/junwang/FV3_RT/rt_250962/control_p8_intel
It is a low resolution C96 case, the restart file is small compared to radiation time.

[junwang-noaa]

@DusanJovic-NOAA would you please review the code again?

[WenMeng-NOAA]

The updates of inline post interface and the upp revision look good to me. Thanks!

[FernandoAndrade-NOAA]

Ok, all conversations are resolved and testing for #1823 has completed successfully, please continue with the merge process.