Skip to content

Fixed stratosphere warm bias and code optimization for MERRA2 #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianCurtis-NOAA merged 5 commits into from
Jul 24, 2023
Merged

Fixed stratosphere warm bias and code optimization for MERRA2 #674

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02b4b82
optimized the code and decrease the stratosphere warm bias for mraero…
AnningCheng-NOAA Jun 29, 2023
d63ba56
update .gitmodules for testing
grantfirl Jun 30, 2023
bb14e67
Merge branch 'develop' into strat_warm_bias_fix_cheng
grantfirl Jul 19, 2023
db6cda3
update ccpp/physics and revert .gitmodules
grantfirl Jul 24, 2023
5689a5c
correct .gitmodules
grantfirl Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
url = https://github.com/NCAR/ccpp-physics
branch = main
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
4 changes: 4 additions & 0 deletions ccpp/data/CCPP_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,8 @@ subroutine gfs_interstitial_setup_tracers(Interstitial, Model)
if (Model%imp_physics == Model%imp_physics_thompson) then
if (Model%ltaerosol) then
Interstitial%nvdiff = 12
else if (Model%mraerosol) then
Comment thread
BrianCurtis-NOAA marked this conversation as resolved.
Interstitial%nvdiff = 10
else
Interstitial%nvdiff = 9
endif
Expand Down Expand Up @@ -1018,6 +1020,8 @@ subroutine gfs_interstitial_setup_tracers(Interstitial, Model)
elseif (Model%imp_physics == Model%imp_physics_thompson) then
if (Model%ltaerosol) then
Interstitial%nvdiff = 12
else if (Model%mraerosol) then
Interstitial%nvdiff = 10
else
Interstitial%nvdiff = 9
endif
Expand Down
2 changes: 1 addition & 1 deletion ccpp/physics
Open in desktop
Submodule physics updated 3 files
+1 −6 physics/GFS_rrtmgp_cloud_mp.F90
+12 −8 physics/module_mp_thompson.F90
+11 −9 physics/mp_thompson.F90