FV3 changes for refactored ozone physics scheme#661
Merged
Conversation
dustinswales
commented
May 26, 2023
41 tasks
grantfirl
reviewed
Aug 2, 2023
grantfirl
reviewed
Aug 2, 2023
Collaborator
Author
|
@grantfirl I'm moving this PR, and the UWM PR, back to draft. It needs more input from othesr. |
grantfirl
reviewed
Oct 26, 2023
Collaborator
|
@dustinswales Can you pull in the latest ccpp-framework to this PR and update the description to say that we're doing this: NCAR/ccpp-framework@219f2e9 ? I've tested this commit of the ccpp-framework using UFS-RTs and everything was bit-for-bit, so this should not change any baselines. |
jkbk2004
approved these changes
Nov 1, 2023
DusanJovic-NOAA
approved these changes
Nov 1, 2023
Collaborator
Author
|
@DusanJovic-NOAA Ready to merge |
BrianCurtis-NOAA
approved these changes
Nov 2, 2023
Merged
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains modifications to accommodate changes to the NRL ozone physics parameterization.
There are new interstitials variables for the data needed by the ozone scheme. The scheme data is ingested in GFS_typedefs:control_initialize() and provided to the scheme via interstitials, previously this data was stored on the HEAP within the scheme. Organizing the scheme this way removes the need for the scheme to access shared memory, making the scheme "stateless".
Issue(s) addressed
ccpp-physics #74
Testing
Coming soon...