Bugfixes for RRTMGP#655
Merged
Merged
Conversation
added 2 commits
May 11, 2023 11:19
37 tasks
added 2 commits
June 6, 2023 21:23
Collaborator
|
Testing on #1751 has completed successfully and CCPP sub pr #70 has been merged in. @dustinswales could you revert gitmodules, update hash, and assign reviewers to approve? |
Collaborator
Author
|
@FernandoAndrade-NOAA Done, well everything but adding reviewers (I don't have permissions) |
Collaborator
|
@jkbk2004 Could you add reviewers? It looks like I also don't have permissions |
jkbk2004
requested review from
DusanJovic-NOAA,
Qingfu-Liu,
jkbk2004 and
junwang-noaa
DusanJovic-NOAA
approved these changes
Jun 8, 2023
Qingfu-Liu
approved these changes
Jun 8, 2023
jkbk2004
approved these changes
Jun 8, 2023
junwang-noaa
approved these changes
Jun 8, 2023
Collaborator
|
This PR is approved as well and ready for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a bug fix to all multiple threads for the RRTMGP radiation scheme in the ccpp-physics. There are no changes to any other FV3 components.
Issue(s) addressed
Addresses UWM:ccpp-physics Issue #59
Testing
Tested on Cheyenne Intel.
Changes to ONLY control_p8_rrtmgp regression test baselines