Skip to content

Update surface net heat fluxes for AQM coupling (was #575)#578

Merged
jkbk2004 merged 3 commits into
NOAA-EMC:developfrom
BrianCurtis-NOAA:bugfix/aqm-heat-fluxes
Sep 9, 2022
Merged

Update surface net heat fluxes for AQM coupling (was #575)#578
jkbk2004 merged 3 commits into
NOAA-EMC:developfrom
BrianCurtis-NOAA:bugfix/aqm-heat-fluxes

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Sep 6, 2022

Helping @rmontuoro out with this PR, taking over to update to latest devel

Description

This PR introduces CCPP updates to rectify the formulation of surface net heat fluxes used for AQM coupling.

Issue(s) addressed

Testing

These changes were tested on the Hera/Intel platform.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

@grantfirl
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA NCAR/ccpp-physics#962 has been merged

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Sep 9, 2022

@BrianCurtis-NOAA cpp#962 was merged. we can start merging in this pr with ccpp hash pointer update.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

It's ready.

@jkbk2004 jkbk2004 self-requested a review September 9, 2022 16:18
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Sep 9, 2022

@DusanJovic-NOAA @ChunxiZhang-NOAA can we have final approvals to merge in?

@jkbk2004 jkbk2004 merged commit 01f40e6 into NOAA-EMC:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface upward heat fluxes for coupling are not properly calculated when (cplaqm .and. .not.cplflx) is ture in GFS_PBL_generic_post.F90

5 participants