Upp inline post for RRFS and HAFS#567
Merged
Merged
Conversation
3)output lat/lon of four corner point for rotated lat-lon grid.
16 tasks
jkbk2004
requested review from
BenjaminBlake-NOAA,
BinLiu-NOAA,
DeniseWorthen and
junwang-noaa
Collaborator
|
Upstream ufs-wm PR#1360 was fully tested ok. Can we have final review and start merging in the PR? |
junwang-noaa
approved these changes
Aug 18, 2022
DeniseWorthen
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will update inline post with changes:
Is a change of answers expected from this PR? No.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on WCOSS2 dogwood.
No changes in regression test baseline right now because the model is not set to output instant model top longwave yet.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? No.