Ignore checksum option and performance with (1,1) io layout#556
Merged
Conversation
…_layout=1,1 and allow one to override data integrity checks in FMS restart logic
junwang-noaa
requested review from
BinLiu-NOAA,
DusanJovic-NOAA and
EricRogers-NOAA
DusanJovic-NOAA
approved these changes
Jun 15, 2022
Collaborator
|
@BinLiu-NOAA @EricRogers-NOAA ufs-wm RT tests were done for this PR thru PR 1294. We can start merging process for this PR with your final comments |
DusanJovic-NOAA
changed the title
BrianCurtis-NOAA
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR includes code changes related to dycore NOAA-GFDL/GFDL_atmos_cubed_sphere#197. In PR#197, an option is added to allow one to override restart data integrity checks enforced for FMS-based io, also the PR has enhancements to improve new FMS-based io when using an io_layout of (1,1)
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
The code changes have been tested in global, regional and hafs applications.
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies